Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Riot on Safari may attempt to render Variation Selector-16 (white boxes) between emoji #9895

Closed
aaronraimist opened this issue May 29, 2019 · 6 comments · Fixed by matrix-org/matrix-react-sdk#4710
Closed

Riot on Safari may attempt to render Variation Selector-16 (white boxes) between emoji #9895

aaronraimist opened this issue May 29, 2019 · 6 comments · Fixed by matrix-org/matrix-react-sdk#4710
Assignees
@ara4n
Labels
A-Emoji P1 T-Defect Z-Platform-Specific

Comments

@aaronraimist
Copy link
Collaborator

https://emojipedia.org/variation-selector-16/

Screen Shot 2019-05-29 at 2 21 10 PM

Version information

  • Platform: web

For the web app:

  • Browser: Safari 12
  • OS: macOS 10.14.5
  • URL: riot.im/develop
@jryans jryans added A-Emoji and removed A-Emoji labels May 30, 2019
@lampholder
Copy link
Member

How do you trigger this?

@lampholder lampholder added the X-Needs-Info This issue is blocked awaiting information from the reporter label May 31, 2019
@jryans
Copy link
Collaborator

jryans commented May 31, 2019

I have observed this in Safari for any emoji that have skin tone variants, even when an actual tone is not being used.

For example the :thumbup: emoji does not include an actual skin tone modifier, but it does include a second character which is this variation selector. In Safari only, this second part displays as a box.

@aaronraimist
Copy link
Collaborator Author

Yeah I guess it would happen with any of these https://unicode.org/emoji/charts/emoji-variants.html#270f emoji which have multiple styles

Screen Shot 2019-06-05 at 2 01 56 PM
Screen Shot 2019-06-05 at 1 56 03 PM

@aaronraimist
Copy link
Collaborator Author

aaronraimist commented Jun 5, 2019 •
edited
Loading

This old PR looks related matrix-org/matrix-react-sdk#1458

@lampholder lampholder added Z-Platform-Specific P1 ui/ux and removed X-Needs-Info This issue is blocked awaiting information from the reporter labels Jun 6, 2019
@jryans jryans changed the title Riot may attempt to render Variation Selector-16 (white boxes) between emoji Riot on Safari may attempt to render Variation Selector-16 (white boxes) between emoji Jun 24, 2019
@jryans jryans mentioned this issue Aug 13, 2019
Closed
@aaronraimist
Copy link
Collaborator Author

Screen Shot 2019-11-08 at 9 24 52 AM

Still an issue 😢

@aaronraimist aaronraimist mentioned this issue Feb 19, 2020
Closed
@aaronraimist aaronraimist mentioned this issue Jun 4, 2020
Closed
@t3chguy
Copy link
Member

t3chguy commented Jun 4, 2020

re-opening until the font created by that patch lands on develop

@t3chguy t3chguy reopened this Jun 4, 2020
@ara4n ara4n mentioned this issue Jun 4, 2020
Merged
@jryans jryans removed the Z-UI/UX label Mar 9, 2021
lgrahl pushed a commit to lgrahl/twemoji-colr that referenced this issue Jul 22, 2022
@ara4n @lgrahl
explicitly add all VS-16 ligatures to appease Safari
e952a7a 
fixes element-hq/element-web#9895
VS-16 list taken from https://unicode.org/emoji/charts/emoji-variants.html
will need to be kept in sync with latest emoji
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ara4n ara4n

Labels
A-Emoji P1 T-Defect Z-Platform-Specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix emoji in safari matrix-org/matrix-react-sdk
5 participants
@jryans @ara4n @lampholder @t3chguy @aaronraimist