Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cryptography information in devtools #29073

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Conversation

florianduros
Copy link
Member

@florianduros florianduros commented Jan 22, 2025

#26468 will remove the secure backup and cross signing section of the Security & Privacy tab. Theses infos are added to the devtools because they can be useful for debugging.

This is the same the same as the old "Advanced" sections from Security & privacy (except the homeserver feature support line is removed)

image

@florianduros florianduros added the T-Task Tasks for the team like planning label Jan 22, 2025
@florianduros florianduros force-pushed the florianduros/devtools-crypto branch from aacab8e to c17f47a Compare January 22, 2025 16:38
@florianduros florianduros force-pushed the florianduros/devtools-crypto branch from c17f47a to d52c2f2 Compare January 22, 2025 17:42
@florianduros florianduros changed the title Add cryptographic information in devtools Add cryptography information in devtools Jan 22, 2025
@florianduros florianduros force-pushed the florianduros/devtools-crypto branch from d3a7b16 to 9d10ed4 Compare January 23, 2025 08:38
@florianduros florianduros force-pushed the florianduros/devtools-crypto branch from abebfae to 1a2dd67 Compare January 23, 2025 09:07
@florianduros florianduros force-pushed the florianduros/devtools-crypto branch from 1a2dd67 to 7a17bba Compare January 23, 2025 09:11
@florianduros florianduros force-pushed the florianduros/devtools-crypto branch from 7a17bba to b72b6d3 Compare January 23, 2025 09:53
@florianduros florianduros force-pushed the florianduros/devtools-crypto branch from b72b6d3 to a54984c Compare January 23, 2025 13:11
@florianduros florianduros force-pushed the florianduros/devtools-crypto branch from a54984c to 4ad725d Compare January 23, 2025 13:44
@richvdh
Copy link
Member

richvdh commented Jan 23, 2025

@florianduros could you mention in the description if is this exactly the same as the old "Advanced" sections from Security & privacy, or if not, how it is different?

(while you're there, may as well remove the checklist)

@florianduros
Copy link
Member Author

florianduros commented Jan 23, 2025

@richvdh Yes, this is the same, I updated the PR description.

Which checklist? If you are talking about the checklist in Security & Privacy, I'll do it in a dedicated PR. (And we need #29066 to land first)

@richvdh
Copy link
Member

richvdh commented Jan 23, 2025

The checklist in the PR description, that is serving no purpose and making it hard to read the description ;)

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

src/i18n/strings/en_EN.json Outdated Show resolved Hide resolved
@florianduros florianduros force-pushed the florianduros/devtools-crypto branch from 882c522 to 7fd2a06 Compare January 24, 2025 10:10
@dbkr
Copy link
Member

dbkr commented Jan 24, 2025

Forcing because sonar is confused thinking that two table layouts are duplicated code.

@dbkr dbkr merged commit a73eb37 into develop Jan 24, 2025
30 of 31 checks passed
@dbkr dbkr deleted the florianduros/devtools-crypto branch January 24, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants