Use the user's pre-existing HS when config validation fails #9892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwindels
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires matrix-org/matrix-react-sdk#3043
Fixes #9835
This is a temporary measure for #9828
Only applies if the user appears to be logged in. If the user is not logged in, we scream loudly.
A note on the messaging: The errors being displayed to users come from deep within the js-sdk, which is not easily translated. Instead of trying to wrestle a homeserver URL into the error, I've just stuck a sentence into the error box to hopefully make it clear that it's not the user's fault.
Pretend that says "Homeserver URL does not appear to be a valid homeserver" instead of "Unexpected error"