Rename field of RoomDetailsType.Dm for clarity

element-hq · Jun 24, 2024 · 5ccaeea · 5ccaeea
1 parent f0917ad
commit 5ccaeea
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/...impl/src/main/kotlin/io/element/android/features/roomdetails/impl/RoomDetailsPresenter.kt b/...impl/src/main/kotlin/io/element/android/features/roomdetails/impl/RoomDetailsPresenter.kt
@@ -175,7 +175,7 @@ class RoomDetailsPresenter @Inject constructor(
             if (dmMember != null && currentMember != null) {
                 RoomDetailsType.Dm(
                     me = currentMember,
-                    roomMember = dmMember,
+                    otherMember = dmMember,
                 )
             } else {
                 RoomDetailsType.Room

diff --git a/...ils/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/RoomDetailsState.kt b/...ils/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/RoomDetailsState.kt
@@ -54,7 +54,7 @@ sealed interface RoomDetailsType {
     data object Room : RoomDetailsType
     data class Dm(
         val me: RoomMember,
-        val roomMember: RoomMember,
+        val otherMember: RoomMember,
     ) : RoomDetailsType
 }
 

diff --git a/...ails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/RoomDetailsView.kt b/...ails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/RoomDetailsView.kt
@@ -139,7 +139,7 @@ fun RoomDetailsView(
                 is RoomDetailsType.Dm -> {
                     DmHeaderSection(
                         me = state.roomType.me,
-                        otherMember = state.roomType.roomMember,
+                        otherMember = state.roomType.otherMember,
                         roomName = state.roomName,
                         openAvatarPreview = { name, avatarUrl ->
                             openAvatarPreview(name, avatarUrl)

diff --git a/.../impl/src/test/kotlin/io/element/android/features/roomdetails/RoomDetailsPresenterTest.kt b/.../impl/src/test/kotlin/io/element/android/features/roomdetails/RoomDetailsPresenterTest.kt
@@ -172,7 +172,7 @@ class RoomDetailsPresenterTest {
             assertThat(initialState.roomType).isEqualTo(
                 RoomDetailsType.Dm(
                     me = myRoomMember,
-                    roomMember = otherRoomMember,
+                    otherMember = otherRoomMember,
                 )
             )
             cancelAndIgnoreRemainingEvents()