Fix detekt issues

element-hq · Apr 26, 2024 · 636c024 · 636c024
1 parent cf06aca
commit 636c024
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/...s/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/TimelineView.kt b/...s/impl/src/main/kotlin/io/element/android/features/messages/impl/timeline/TimelineView.kt
@@ -235,14 +235,15 @@ private fun BoxScope.TimelineScrollHelper(
         }
     }
 
+    val latestOnClearFocusRequestState by rememberUpdatedState(onClearFocusRequestState)
     LaunchedEffect(focusRequestState) {
         if (focusRequestState is FocusRequestState.Cached) {
             if (abs(lazyListState.firstVisibleItemIndex - focusRequestState.index) < 10) {
                 lazyListState.animateScrollToItem(focusRequestState.index)
             } else {
                 lazyListState.scrollToItem(focusRequestState.index)
             }
-            onClearFocusRequestState()
+            latestOnClearFocusRequestState()
         }
     }
 

diff --git a/...n/kotlin/io/element/android/features/messages/impl/timeline/components/TimelineItemRow.kt b/...n/kotlin/io/element/android/features/messages/impl/timeline/components/TimelineItemRow.kt
@@ -135,6 +135,7 @@ internal fun TimelineItemRow(
     }
 }
 
+@Suppress("ModifierComposable")
 @Composable
 private fun Modifier.focusedEvent(
     focusedEventOffset: Dp

diff --git a/...n/io/element/android/features/messages/impl/timeline/components/TimelineItemVirtualRow.kt b/...n/io/element/android/features/messages/impl/timeline/components/TimelineItemVirtualRow.kt
@@ -20,6 +20,8 @@ import androidx.compose.foundation.layout.Box
 import androidx.compose.foundation.layout.Spacer
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
+import androidx.compose.runtime.getValue
+import androidx.compose.runtime.rememberUpdatedState
 import androidx.compose.ui.Modifier
 import io.element.android.features.messages.impl.timeline.TimelineEvents
 import io.element.android.features.messages.impl.timeline.TimelineRoomInfo
@@ -51,8 +53,9 @@ fun TimelineItemVirtualRow(
             TimelineItemRoomBeginningModel -> TimelineItemRoomBeginningView(roomName = timelineRoomInfo.name)
             is TimelineItemLoadingIndicatorModel -> {
                 TimelineLoadingMoreIndicator(virtual.model.direction)
+                val latestEventSink by rememberUpdatedState(eventSink)
                 LaunchedEffect(virtual.model.timestamp) {
-                    eventSink(TimelineEvents.LoadMore(virtual.model.direction))
+                    latestEventSink(TimelineEvents.LoadMore(virtual.model.direction))
                 }
             }
             is TimelineItemLastForwardIndicatorModel -> {

diff --git a/...ix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/timeline/RustTimeline.kt b/...ix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/timeline/RustTimeline.kt
@@ -222,7 +222,8 @@ class RustTimeline(
                     isDm = matrixRoom.isDm,
                     hasMoreToLoadBackwards = hasMoreToLoadBackward
                 )
-            }.let { items -> loadingIndicatorsPostProcessor.process(items, hasMoreToLoadBackward, hasMoreToLoadForward) }
+            }
+            .let { items -> loadingIndicatorsPostProcessor.process(items, hasMoreToLoadBackward, hasMoreToLoadForward) }
             // Keep lastForwardIndicatorsPostProcessor last
             .let { items -> lastForwardIndicatorsPostProcessor.process(items) }
     }