Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward message: room list display roomId #1970

Closed
bmarty opened this issue Dec 7, 2023 · 0 comments · Fixed by #2061
Closed

Forward message: room list display roomId #1970

bmarty opened this issue Dec 7, 2023 · 0 comments · Fixed by #2061
Assignees
@bmarty
Labels
A-Room Picker O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@bmarty
Copy link
Member

bmarty commented Dec 7, 2023

When forwarding a message, the room list displayed for the user to pick a room render roomIds when the room does not have an alias, which is a bit techie.

image

From Figma, it looks like we should render other userId for DM. If there is no alias for room, I guess we could hide the subtitle as it's done on the current app.
@bmarty bmarty added S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems O-Occasional Affects or can be seen by some users regularly or most users rarely A-Room Picker labels Dec 7, 2023
@bmarty bmarty self-assigned this Dec 7, 2023
bmarty added a commit that referenced this issue Dec 19, 2023
@bmarty
Do not render roomId if the room has no canonical alias #1970
5ea59fe
@bmarty bmarty mentioned this issue Dec 19, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
A-Room Picker O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not render roomId element-hq/element-x-android
1 participant
@bmarty