Last session recovery #2421
Last session recovery #2421
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2421 +/- ##
==========================================
Coverage ? 72.44%
==========================================
Files ? 1357
Lines ? 32261
Branches ? 6259
==========================================
Hits ? 23373
Misses ? 5658
Partials ? 3230 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
It's not a new issue but the word Enter... on this screenshot looks off
bmarty
force-pushed
the
feature/bma/lastSessionRecovery
branch
from
2cfa5a5 to
0642820
Compare
Also get the sessionVerificationService from the matrixClient, instead of injecting it separately.
…ecovery key banner.
…ner which ask the user to do so.
…nd so the listeners are stopped.
…lue change. The session can become verified when the user enters their recovery key, and in this case the callback `didFinish` is not invoked.
bmarty
force-pushed
the
feature/bma/lastSessionRecovery
branch
from
db09349 to
d3d76dd
Compare
|
| @Composable | ||
| override fun View(modifier: Modifier) { | ||
| val state = presenter.present() | ||
| VerifySelfSessionView( | ||
| state = state, | ||
| modifier = modifier, | ||
| onEnterRecoveryKey = { onEnterRecoveryKey() }, |
| fun start() { | ||
| service.backupStateListener(object : BackupStateListener { | ||
| backupStateListenerTaskHandle = service.backupStateListener(object : BackupStateListener { |
There was a problem hiding this comment.
Use mxCallbackFlow instead, so we can remove this start function. Maybe create extension methods on Encryption so you can reuse them.
private val backupStateFlow = mxCallbackFlow {
val listener = object : BackupStateListener {
override fun onUpdate(status: RustBackupState) {
trySend(backupStateMapper.map(status))
}
}
service.backupStateListener(listener)
}.stateIn(sessionCoroutineScope, SharingStarted.Eagerly, service.backupState().let(backupStateMapper::map))
private val recoveryStateFlow = mxCallbackFlow {
val listener = object : RecoveryStateListener {
override fun onUpdate(status: org.matrix.rustcomponents.sdk.RecoveryState) {
trySend(recoveryStateMapper.map(status))
}
}
service.recoveryStateListener(listener)
}.stateIn(sessionCoroutineScope, SharingStarted.Eagerly, service.recoveryState().let(recoveryStateMapper::map))
|
@ganfra thanks for your review. I'll handle your remarks in a dedicated PR. I also want to add some Maestro test which will enter recovery key. |
Type of change
Content
Add a way to let the user enter a recovery key when there is no other sessions available.
Also update the UI flow, when clicking on the verification banner : either directly open the verification screens (instead of opening the settings), or directly open the "enter recovery key" screen (instead of opening the verification screens, which is non-sense since there are no other sessions).
isLastDeviceis now aStateFlow, to help having more dynamic UI.FeatureFlags.SecureStorageis removed.Motivation and context
Closes #2400
Screenshots / GIFs
Tests
When verifying a session, it's also possible to choose to enter a recovery key instead.
See the recorded screenshot for more details.
Tested devices
Checklist