Test recovery key #2429
Merged
Test recovery key #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Node decide how to navigate.
bmarty
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
ganfra
reviewed
Feb 22, 2024
| trySend(backupStateMapper.map(status)) | ||
| } | ||
| } | ||
| service.backupStateListener(listener) |
There was a problem hiding this comment.
I'd have offer this as extension methods as we already do that in several places (RoomList, Timeline...)
There was a problem hiding this comment.
Yes, sorry, I forgot this: 7d4cf6d
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2429 +/- ##
========================================
Coverage 72.44% 72.45%
========================================
Files 1357 1357
Lines 32261 32263 +2
Branches 6259 6259
========================================
+ Hits 23373 23375 +2
Misses 5658 5658
Partials 3230 3230 ☔ View full report in Codecov by Sentry. |
bmarty
force-pushed
the
feature/bma/testRecoveryKey
branch
from
e13a590 to
7d4cf6d
Compare
bmarty
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
|
bmarty
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
ganfra
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complement for #2421: handle @ganfra 's remarks, and add Maestro test on entering Recovery Key to verify the session.
The RecoveryKey has been added to the GH secret, but will be visible on Maestro recording, this is OK I think, this is just a test account. The account password is still not visible.