Remove join button on room directory search

[jmartinesp]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Removed the 'Join' button in the room directory search result items.

Motivation and context

Product design decision: it took too much space and you can join the room by opening it and tapping on 'Join'.

Screenshots / GIFs

Before	After

Tests

• Enable room directory search in the feature flags.
• On the room list, tap on the search button, then 'Browse all rooms'.
• Not joined rooms should not display the 'Join' button anymore.

Tested devices

• Physical
• Emulator
• OS version(s): 14

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Kby7tF

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.95%. Comparing base (2f19f57) to head (34b8b6c).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2827      +/-   ##
===========================================
- Coverage    73.96%   73.95%   -0.01%     
===========================================
  Files         1530     1530              
  Lines        36555    36539      -16     
  Branches      7076     7074       -2     
===========================================
- Hits         27038    27023      -15     
  Misses        5811     5811              
+ Partials      3706     3705       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bmarty]

Thanks!