-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It's not possible to join room from the RoomDirectory screen anymore. #2839
Conversation
37cd3e1
to
5814de1
Compare
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2839 +/- ##
===========================================
- Coverage 73.96% 73.95% -0.01%
===========================================
Files 1531 1531
Lines 36536 36505 -31
Branches 7074 7069 -5
===========================================
- Hits 27024 26999 -25
+ Misses 5809 5804 -5
+ Partials 3703 3702 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup! I left if there in case we wanted to re-enable it in the future with some other UI, but it's probably not the case so it's better to just get rid of it.
(Yes, I needed to do some cleanup to simplify another coming PR) |
Cleanup after #2827