Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show poll question in timeline replies #1857

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Show poll question in timeline replies #1857

merged 1 commit into from
Nov 22, 2023

Conversation

julioromano
Copy link

Forgot to add this bit to: #1848

@julioromano julioromano self-assigned this Nov 22, 2023
@julioromano julioromano requested a review from a team as a code owner November 22, 2023 14:12
@julioromano julioromano requested review from jmartinesp and removed request for a team November 22, 2023 14:12
@julioromano julioromano mentioned this pull request Nov 22, 2023
Closed
@julioromano julioromano enabled auto-merge (squash) November 22, 2023 14:16
@julioromano julioromano disabled auto-merge November 22, 2023 14:22
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2023 •
edited
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e269303) 63.62% compared to head (3ae9422) 63.61%.

Files Patch % Lines
...s/impl/timeline/components/TimelineItemEventRow.kt 14.28% 2 Missing and 4 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1857      +/-   ##
===========================================
- Coverage    63.62%   63.61%   -0.01%     
===========================================
  Files         1314     1314              
  Lines        34290    34292       +2     
  Branches      7103     7104       +1     
===========================================
  Hits         21816    21816              
- Misses        9226     9228       +2     
  Partials      3248     3248

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julioromano julioromano force-pushed the julioromano/polls_reply_fix branch 2 times, most recently from b7935c0 to 20410b9 Compare November 22, 2023 14:45
Show poll question in timeline replies
3ae9422 
Forgot to add this bit to: #1848
@julioromano julioromano force-pushed the julioromano/polls_reply_fix branch from 83413d2 to 3ae9422 Compare November 22, 2023 14:48
@julioromano julioromano enabled auto-merge (squash) November 22, 2023 14:48
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions GitHub Actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/aCxeoh

@julioromano julioromano disabled auto-merge November 22, 2023 15:13
@jmartinesp jmartinesp merged commit bc5c02c into develop Nov 22, 2023
@jmartinesp jmartinesp deleted the julioromano/polls_reply_fix branch November 22, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinesp jmartinesp jmartinesp approved these changes

Assignees

@julioromano julioromano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julioromano @jmartinesp