-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract compound tokens and theming to compound-android
library
#1888
Extract compound tokens and theming to compound-android
library
#1888
Conversation
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
9ef8afb
to
67701fa
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1888 +/- ##
===========================================
- Coverage 66.10% 64.81% -1.30%
===========================================
Files 1326 1308 -18
Lines 34480 33071 -1409
Branches 7129 7087 -42
===========================================
- Hits 22792 21434 -1358
+ Misses 8338 8311 -27
+ Partials 3350 3326 -24 ☔ View full report in Codecov by Sentry. |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, even if I cannot compare the screenshot in GH interface, so hard to see if there is a problem without checking manually the whole app.
Type of change
Content
Compound tokens and theme are now in https://github.com/vector-im/compound-android.
Motivation and context
Closes #1833 .
Screenshots / GIFs
There are lots of screenshot changes because some files were moved to other modules/packages.
Tested devices
Checklist