Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract compound tokens and theming to compound-android library #1888

Merged
merged 9 commits into from
Nov 27, 2023

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Nov 24, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Compound tokens and theme are now in https://github.com/vector-im/compound-android.

Motivation and context

Closes #1833 .

Screenshots / GIFs

There are lots of screenshot changes because some files were moved to other modules/packages.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@ElementBot
Copy link
Collaborator

ElementBot commented Nov 24, 2023

Warnings
⚠️

features/createroom/impl/src/main/kotlin/io/element/android/features/createroom/impl/configureroom/ConfigureRoomView.kt#L35 - Using a material import while also using the material3 library

⚠️

features/createroom/impl/src/main/kotlin/io/element/android/features/createroom/impl/configureroom/ConfigureRoomView.kt#L36 - Using a material import while also using the material3 library

⚠️

features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/user/editprofile/EditUserProfileView.kt#L30 - Using a material import while also using the material3 library

⚠️

features/preferences/impl/src/main/kotlin/io/element/android/features/preferences/impl/user/editprofile/EditUserProfileView.kt#L31 - Using a material import while also using the material3 library

⚠️

features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/edit/RoomDetailsEditView.kt#L34 - Using a material import while also using the material3 library

⚠️

features/roomdetails/impl/src/main/kotlin/io/element/android/features/roomdetails/impl/edit/RoomDetailsEditView.kt#L35 - Using a material import while also using the material3 library

Generated by 🚫 dangerJS against 15acf05

Copy link
Contributor

github-actions bot commented Nov 24, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/JqSnjE

@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 27, 2023
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 27, 2023
@jmartinesp jmartinesp force-pushed the misc/jme/extract-compound-android-library branch from 9ef8afb to 67701fa Compare November 27, 2023 07:39
@jmartinesp jmartinesp added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 27, 2023
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (298e5a6) 66.10% compared to head (15acf05) 64.81%.

Files Patch % Lines
...in/impl/screens/loginpassword/LoginPasswordView.kt 0.00% 0 Missing and 2 partials ⚠️
...aries/designsystem/components/button/BackButton.kt 0.00% 0 Missing and 2 partials ⚠️
...id/libraries/designsystem/theme/components/Icon.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1888      +/-   ##
===========================================
- Coverage    66.10%   64.81%   -1.30%     
===========================================
  Files         1326     1308      -18     
  Lines        34480    33071    -1409     
  Branches      7129     7087      -42     
===========================================
- Hits         22792    21434    -1358     
+ Misses        8338     8311      -27     
+ Partials      3350     3326      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp marked this pull request as ready for review November 27, 2023 08:30
@jmartinesp jmartinesp requested a review from a team as a code owner November 27, 2023 08:30
@jmartinesp jmartinesp requested review from julioromano and removed request for a team November 27, 2023 08:30
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, even if I cannot compare the screenshot in GH interface, so hard to see if there is a problem without checking manually the whole app.

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 27, 2023
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 27, 2023
@jmartinesp jmartinesp merged commit 087d272 into develop Nov 27, 2023
@jmartinesp jmartinesp deleted the misc/jme/extract-compound-android-library branch November 27, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract Compound tokens to their own library and automate its releases
3 participants