Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rendering of voice messages in the timeline in large displays #2199

Merged

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Redo a bit the canvas drawing and pointer handling for the WaveformPlaybackView so the playback cursor doesn't go out of the actual waveform while playing/scrubbing.

Motivation and context

Fixes #2156 , although only partially. Ideally, we should also make voice messages a bit smaller in large screen sizes, but that would require large changes in measuring and layout.

Screenshots / GIFs

In the PR. There are diffs, but AFAICT they're more accurate. i.e this screenshot is supposed to display 50% progress.

Tests

  • Open a room in landscape mode.
  • Record a voice message, play a bit with the scrubbing and play/pause states.
  • Send the voice message, play a bit with the timeline item too.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

@jmartinesp jmartinesp requested a review from a team as a code owner January 9, 2024 15:29
@jmartinesp jmartinesp requested review from ganfra and removed request for a team January 9, 2024 15:29
Copy link

sonarqubecloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 9, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/JiNBcJ

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (e8c6226) 67.01% compared to head (e53ce4b) 67.01%.
Report is 2 commits behind head on develop.

Files Patch % Lines
...ignsystem/components/media/WaveformPlaybackView.kt 69.23% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2199   +/-   ##
========================================
  Coverage    67.01%   67.01%           
========================================
  Files         1376     1376           
  Lines        34263    34264    +1     
  Branches      7460     7460           
========================================
+ Hits         22961    22962    +1     
  Misses        7677     7677           
  Partials      3625     3625           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jan 9, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Jan 9, 2024
@jmartinesp jmartinesp merged commit 13e8e95 into develop Jan 9, 2024
@jmartinesp jmartinesp deleted the fix/jme/2156-large-voice-screen-messages-look-broken branch January 9, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large screen voice messages are visually broken
2 participants