Add legacy call invite state events and notifications #2552

jmartinesp · 2024-03-14T14:37:19Z

Type of change

Feature
Bugfix
Technical
Other :

Content

Add a legacy call invite state event to the timeline.
Display a notification when a legacy call invite is received.

Motivation and context

Closes #2485

Screenshots / GIFs

In the PR (most of them are accidental renames thanks to Showkase...).

Tests

From another client, start a legacy (jitsi) call in a DM.
Check the notifications arrives and is displayed in EXA.
Open the notification, check the a state event-like timeline item is displayed for it.

Tested devices

Physical
Emulator
OS version(s): 14

Checklist

Changes have been tested on an Android device or Android emulator with API 23
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
Pull request includes screenshots or videos if containing UI changes
Pull request includes a sign off
You've made a self review of your PR

github-actions · 2024-03-14T14:47:47Z

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pcZMit

bmarty

Thanks for this work. I believe the body parameter may be removed, and it will fix all my remark at once. Let me know if I am wrong!

bmarty · 2024-03-14T14:57:45Z

...t/android/features/messages/impl/timeline/model/event/TimelineItemLegacyCallInviteContent.kt

+import io.element.android.libraries.matrix.api.timeline.item.event.EventType
+
+data class TimelineItemLegacyCallInviteContent(
+    val body: String,


I would remove this field, since at the end we setting the value to stringProvider.getString(CommonStrings.common_call_invite). Or is it for future usage?

Not really, but having the field here avoids having to retrieve the strings in a couple of other places. I can move it to those other places since it's true it doesn't add much value and can be a source of future issues.

bmarty · 2024-03-14T14:58:30Z

...o/element/android/features/messages/impl/utils/messagesummary/MessageSummaryFormatterImpl.kt

@@ -63,6 +64,7 @@ class MessageSummaryFormatterImpl @Inject constructor(
            is TimelineItemVideoContent -> context.getString(CommonStrings.common_video)
            is TimelineItemFileContent -> context.getString(CommonStrings.common_file)
            is TimelineItemAudioContent -> context.getString(CommonStrings.common_audio)
+            is TimelineItemLegacyCallInviteContent -> event.content.body


You can use context.getString(CommonStrings.common_call_invite) here

bmarty · 2024-03-14T15:03:04Z

...android/features/messages/impl/timeline/components/event/TimelineItemLegacyCallInviteView.kt

+@PreviewsDayNight
+@Composable
+internal fun TimelineItemLegacyCallInviteViewPreview() = ElementPreview {
+    TimelineItemLegacyCallInviteView(content = TimelineItemLegacyCallInviteContent(stringResource(CommonStrings.common_call_invite)))


It's also weird to give i18n string in preview object.

bmarty · 2024-03-14T15:05:50Z

...eatures/messages/impl/timeline/factories/event/TimelineItemContentLegacyCallInviteFactory.kt

+import io.element.android.services.toolbox.api.strings.StringProvider
+import javax.inject.Inject
+
+class TimelineItemContentLegacyCallInviteFactory @Inject constructor(


May be removed as well I guess.

codecov · 2024-03-14T15:09:40Z

Codecov Report

Attention: Patch coverage is 62.50000% with 27 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (develop@179579d). Click here to learn what that means.
Report is 1 commits behind head on develop.

❗ Current head 2ea9d9c differs from pull request most recent head 9a43928. Consider uploading reports for the commit 9a43928 to get more accurate results

Files	Patch %	Lines
...es/messages/impl/actionlist/ActionListPresenter.kt	0.00%	3 Missing and 1 partial ⚠️
...e/components/event/TimelineItemEventContentView.kt	0.00%	2 Missing and 1 partial ⚠️
...eatures/messages/impl/actionlist/ActionListView.kt	0.00%	1 Missing and 1 partial ⚠️
...mponents/event/TimelineItemLegacyCallInviteView.kt	86.66%	0 Missing and 2 partials ⚠️
...vent/TimelineItemContentLegacyCallInviteFactory.kt	50.00%	2 Missing ⚠️
...entformatter/impl/DefaultTimelineEventFormatter.kt	0.00%	2 Missing ⚠️
...push/impl/notifications/RoomGroupMessageCreator.kt	71.42%	0 Missing and 2 partials ⚠️
...ndroid/features/messages/impl/MessagesPresenter.kt	0.00%	0 Missing and 1 partial ⚠️
...ssages/impl/timeline/components/TimelineItemRow.kt	0.00%	0 Missing and 1 partial ⚠️
...line/factories/event/TimelineItemContentFactory.kt	66.66%	1 Missing ⚠️
... and 7 more

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #2552   +/-   ##
==========================================
  Coverage           ?   73.17%           
==========================================
  Files              ?     1408           
  Lines              ?    34068           
  Branches           ?     6608           
==========================================
  Hits               ?    24929           
  Misses             ?     5689           
  Partials           ?     3450

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bmarty

Thanks for the fast update!

sonarqubecloud · 2024-03-14T15:20:56Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

jmartinesp and others added 2 commits March 14, 2024 14:24

Add state timeline events and notifications for legacy call invites

c98ea29

Update screenshots

2ea9d9c

jmartinesp requested a review from a team as a code owner March 14, 2024 14:37

jmartinesp requested review from bmarty and removed request for a team March 14, 2024 14:37

bmarty approved these changes Mar 14, 2024

View reviewed changes

bmarty reviewed Mar 14, 2024

View reviewed changes

Remove body field from TimelineItemLegacyCallInviteContent

9a43928

jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Mar 14, 2024

github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Mar 14, 2024

bmarty approved these changes Mar 14, 2024

View reviewed changes

jmartinesp merged commit 67d7905 into develop Mar 14, 2024
16 of 17 checks passed

jmartinesp deleted the feature/jme/2485-add-legacy-call-state-events-and-notifications branch March 14, 2024 15:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add legacy call invite state events and notifications #2552

Add legacy call invite state events and notifications #2552

jmartinesp commented Mar 14, 2024 •

edited

Loading

github-actions bot commented Mar 14, 2024 •

edited

Loading

bmarty left a comment

bmarty Mar 14, 2024

jmartinesp Mar 14, 2024 •

edited

Loading

bmarty Mar 14, 2024

bmarty Mar 14, 2024

bmarty Mar 14, 2024

codecov bot commented Mar 14, 2024 •

edited

Loading

bmarty left a comment

sonarqubecloud bot commented Mar 14, 2024

Add legacy call invite state events and notifications #2552

Add legacy call invite state events and notifications #2552

Conversation

jmartinesp commented Mar 14, 2024 • edited Loading

Type of change

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

github-actions bot commented Mar 14, 2024 • edited Loading

bmarty left a comment

Choose a reason for hiding this comment

bmarty Mar 14, 2024

Choose a reason for hiding this comment

jmartinesp Mar 14, 2024 • edited Loading

Choose a reason for hiding this comment

bmarty Mar 14, 2024

Choose a reason for hiding this comment

bmarty Mar 14, 2024

Choose a reason for hiding this comment

bmarty Mar 14, 2024

Choose a reason for hiding this comment

codecov bot commented Mar 14, 2024 • edited Loading

Codecov Report

bmarty left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Mar 14, 2024

Quality Gate passed

jmartinesp commented Mar 14, 2024 •

edited

Loading

github-actions bot commented Mar 14, 2024 •

edited

Loading

jmartinesp Mar 14, 2024 •

edited

Loading

codecov bot commented Mar 14, 2024 •

edited

Loading