Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to workaround a timeline pagination deadlock #2824

Closed

Conversation

jmartinesp
Copy link
Member

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Added a Mutex to avoid several pagination runs at the same time. This seems to workaround the issue.

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

Added a Mutex to avoid several pagination runs at the same time. This *seems* to workaround the issue.
@ElementBot
Copy link
Collaborator

ElementBot commented May 9, 2024

Warnings
⚠️

features/ftue/impl/src/main/kotlin/io/element/android/features/ftue/impl/state/DefaultFtueService.kt#L42 - The import 'kotlinx.coroutines.runBlocking' is unused.

Generated by 🚫 dangerJS against 7b73f17

Copy link
Contributor

github-actions bot commented May 9, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/DNQ1BH

@jmartinesp jmartinesp force-pushed the fix/jme/workaround-deadlock-when-paginating branch from b012340 to 7b73f17 Compare May 9, 2024 09:42
Copy link

sonarqubecloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.96%. Comparing base (0ed4109) to head (7b73f17).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2824   +/-   ##
========================================
  Coverage    73.96%   73.96%           
========================================
  Files         1530     1530           
  Lines        36549    36549           
  Branches      7075     7075           
========================================
  Hits         27034    27034           
  Misses        5810     5810           
  Partials      3705     3705           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ganfra
Copy link
Member

ganfra commented May 14, 2024

@jmartinesp so from what I've seen, this is not coming from the pagination and the main point has been fixed by https://github.com/matrix-org/matrix-rust-components-kotlin/releases/tag/sdk-v0.2.18 updates (new suspending method).

@jmartinesp
Copy link
Member Author

Perfect, thanks for checking this! I'm closing the PR.

@jmartinesp jmartinesp closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants