Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lifecycle to v2.8.0 #2848

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Update lifecycle to v2.8.0 #2848

merged 4 commits into from
Aug 20, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 15, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
androidx.lifecycle:lifecycle-process (source) 2.7.0 -> 2.8.0 age adoption passing confidence
androidx.lifecycle:lifecycle-runtime-ktx (source) 2.7.0 -> 2.8.0 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner May 15, 2024 08:02
@renovate renovate bot added the PR-Dependencies Pull requests that update a dependency file label May 15, 2024
@renovate renovate bot requested review from jmartinesp and removed request for a team May 15, 2024 08:02
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.71%. Comparing base (9704718) to head (6719ffc).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2848   +/-   ##
========================================
  Coverage    82.71%   82.71%           
========================================
  Files         1679     1679           
  Lines        39334    39334           
  Branches      4767     4767           
========================================
+ Hits         32534    32535    +1     
  Misses        5122     5122           
+ Partials      1678     1677    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 15, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/s3SeW9

Copy link
Contributor Author

renovate bot commented May 15, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jmartinesp
Copy link
Member

There seems to be some incompatibility:

Could not resolve all dependencies for configuration ':features:location:impl:debugTestFixturesCompileClasspath'.
Problems reading data from Binary store in /Users/jorge/.gradle/.tmp/gradle10628180516075242221.bin offset 1728540 exists? true
Problems loading the resolution results (0.012 secs). Read 667 values, last was: 5
Corrupt serialized resolution result. Cannot find selected component (436416) for releaseVariantReleaseRuntimePublication -> androidx.lifecycle:lifecycle-process:2.4.1

This androidx.lifecycle:lifecycle-process:2.4.1 is only used by androidx.compose.ui:ui-text:1.6.7, which is automatically fetched by the Compose BOM version.

@Javernaut
Copy link

Beware of a known issue of lifecycle 2.8.0:

lifecycle-*:2.8.0 requires a minimum Compose version of 1.7.0-alpha05 (b/336842920).

@bmarty
Copy link
Member

bmarty commented Jun 25, 2024

There is a version 2.8.2 now, let's ask Renovate to use it.

Copy link

@jmartinesp
Copy link
Member

There seems to be some incompatibility:

Could not resolve all dependencies for configuration ':features:location:impl:debugTestFixturesCompileClasspath'.
Problems reading data from Binary store in /Users/jorge/.gradle/.tmp/gradle10628180516075242221.bin offset 1728540 exists? true
Problems loading the resolution results (0.012 secs). Read 667 values, last was: 5
Corrupt serialized resolution result. Cannot find selected component (436416) for releaseVariantReleaseRuntimePublication -> androidx.lifecycle:lifecycle-process:2.4.1

This androidx.lifecycle:lifecycle-process:2.4.1 is only used by androidx.compose.ui:ui-text:1.6.7, which is automatically fetched by the Compose BOM version.

We still have this issue.

Copy link

@jmartinesp jmartinesp added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Aug 20, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Aug 20, 2024
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems ok now.

@jmartinesp jmartinesp merged commit e9ad39a into develop Aug 20, 2024
27 checks passed
@jmartinesp jmartinesp deleted the renovate/lifecycle branch August 20, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants