-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let Dms use other member color. #3058
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
modifier = Modifier | ||
.size(70.dp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removal is actually fixing a rendering issue, see the recorded screenshot. The Avatar was not rendered correctly.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3058 +/- ##
===========================================
+ Coverage 75.91% 75.92% +0.01%
===========================================
Files 1628 1631 +3
Lines 38409 38504 +95
Branches 7421 7437 +16
===========================================
+ Hits 29158 29235 +77
- Misses 5375 5387 +12
- Partials 3876 3882 +6 ☔ View full report in Codecov by Sentry. |
Please retry analysis of this Pull-Request directly on SonarCloud |
Type of change
Content
Ensure that a DM will use the same color that the other user color.
Preparatory work for a wider rendering of heroes. Note: the rendering of multiple heroes is currently disabled by ac6e56f.
Motivation and context
Closes #1538
Screenshots / GIFs
For the user:
Here is how it is rendered in the room list:
Tests
Tested devices
Checklist