Use the right filename for log files so they're sorted in rageshakes #3219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3219 +/- ##
========================================
Coverage 76.13% 76.13%
========================================
Files 1645 1645
Lines 38816 38815 -1
Branches 7517 7517
========================================
Hits 29553 29553
+ Misses 5362 5361 -1
Partials 3901 3901 ☔ View full report in Codecov by Sentry. |
ganfra
approved these changes
Jul 19, 2024
| @@ -71,7 +71,7 @@ class TracingInitializer : Initializer<Unit> { | |||
| return WriteToFilesConfiguration.Enabled( | |||
| directory = bugReporter.logDirectory().absolutePath, | |||
| filenamePrefix = "logs", | |||
| filenameSuffix = null, | |||
| filenameSuffix = "log", | |||
There was a problem hiding this comment.
Add a small comment so we don't change this?
jmartinesp
force-pushed
the
fix/jme/use-right-filename-for-logs-in-ragehsakes
branch
from
974e8dc to
34cf54a
Compare
jmartinesp
force-pushed
the
fix/jme/use-right-filename-for-logs-in-ragehsakes
branch
from
34cf54a to
8c3953d
Compare
jmartinesp
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Use the
logsuffix when creating log files so the rageshake server recognises its format and doesn't rename them to justlogs-0001.log.gz,logs-0002.log.gz, etc.Motivation and context
This way we'll have instead
logs-2024-07-19-11.log.gz,logs-2024-07-19-10.log.gz, etc., stating the hour of logs included inside in their filename.Tests
You can upload a test bug report after letting the app run for a while and collect new logs, then check the rageshakes.
https://github.com/element-hq/element-x-android-rageshakes/issues/2410
Checklist