Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure starting PinUnlockActivity does not crash the application. #3369

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Aug 30, 2024

Content

Fix regression from #3222 d4f8052

Motivation and context

Close #3353

Screenshots / GIFs

Tests

  • Set up a pin code
  • Kill the app
  • Start the app
  • the app should not crash now.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner August 30, 2024 14:18
@bmarty bmarty requested review from ganfra and removed request for a team August 30, 2024 14:18
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Sg1j9S

@bmarty bmarty added the PR-Bugfix For bug fix label Aug 30, 2024
Copy link

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.62%. Comparing base (f2ebd93) to head (61f9b20).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
...droid/features/logout/impl/DefaultLogoutUseCase.kt 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3369      +/-   ##
===========================================
- Coverage    82.62%   82.62%   -0.01%     
===========================================
  Files         1683     1682       -1     
  Lines        39456    39458       +2     
  Branches      4798     4799       +1     
===========================================
  Hits         32602    32602              
- Misses        5174     5176       +2     
  Partials      1680     1680              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 2, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 2, 2024
@bmarty bmarty enabled auto-merge September 2, 2024 10:18
@bmarty bmarty merged commit c19229b into develop Sep 2, 2024
31 of 33 checks passed
@bmarty bmarty deleted the feature/bma/fixPinLockCrash branch September 2, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash due to pinunlock activity
2 participants