Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pinned events required state in SlidingSync #3385

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

jmartinesp
Copy link
Member

Content

Make pinned events required state in SlidingSync.

Motivation and context

This is needed to always have the pinned events of a room as soon as we open it.

Tests

  • Enable pinned events in developer settings.
  • Clear cache.
  • Open a room with pinned events that hasn't pinned/unpinned a new one in a while.

The pinned events should be loaded.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

This is needed to always have the pinned events of a room as soon as we open it.
@jmartinesp jmartinesp added the PR-Bugfix For bug fix label Sep 3, 2024
@jmartinesp jmartinesp requested a review from a team as a code owner September 3, 2024 14:53
@jmartinesp jmartinesp requested review from ganfra and removed request for a team September 3, 2024 14:53
Copy link
Contributor

github-actions bot commented Sep 3, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/zbNzJK

Copy link

sonarqubecloud bot commented Sep 3, 2024

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.59%. Comparing base (ae3fd89) to head (1caf4fb).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3385   +/-   ##
========================================
  Coverage    82.59%   82.59%           
========================================
  Files         1693     1693           
  Lines        39646    39646           
  Branches      4822     4822           
========================================
  Hits         32745    32745           
  Misses        5216     5216           
  Partials      1685     1685           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ganfra ganfra enabled auto-merge September 3, 2024 15:21
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 3, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Sep 3, 2024
@ganfra ganfra disabled auto-merge September 3, 2024 15:37
@jmartinesp jmartinesp merged commit 5920fd3 into develop Sep 3, 2024
33 checks passed
@jmartinesp jmartinesp deleted the fix/jme/subscribe-rooms-require-pinned-events branch September 3, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants