Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set caption when uploading file and audio files, and allow adding / edit / remove caption on Event with attachment (also works on local echo) #3902

Merged
merged 12 commits into from
Nov 21, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 20, 2024

Content

Allow to set caption when uploading file and audio files, and allow adding / edit / remove media caption on Event (also work on local echo)

Motivation and context

Closes #3859

Screenshots / GIFs

AddEditRemoveCaptionFull.mp4

Tests

  • Send file with a caption
  • Long click on a media item to see the available options about caption.

Repeat the same actions when in airplane mode. The last state should be sent to the server once the network is back.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner November 20, 2024 13:11
@bmarty bmarty requested review from ganfra and removed request for a team November 20, 2024 13:11
@bmarty bmarty added the PR-Feature For a new feature label Nov 20, 2024
@bmarty bmarty changed the title Allow to set caption when uploading file and audio files, and allow adding / edit / remove media caption on Event (also work on local echo) Allow to set caption when uploading file and audio files, and allow adding / edit / remove caption on Event with attachment (also work on local echo) Nov 20, 2024
@bmarty bmarty changed the title Allow to set caption when uploading file and audio files, and allow adding / edit / remove caption on Event with attachment (also work on local echo) Allow to set caption when uploading file and audio files, and allow adding / edit / remove caption on Event with attachment (also works on local echo) Nov 20, 2024
Copy link
Contributor

github-actions bot commented Nov 20, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/mm8oqB

@bmarty bmarty force-pushed the feature/bma/editMediaCaption branch from cbfaf01 to 800d048 Compare November 21, 2024 08:09
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 93.89671% with 13 lines in your changes missing coverage. Please review.

Project coverage is 82.95%. Comparing base (ee50b50) to head (ae94b44).
Report is 14 commits behind head on develop.

Files with missing lines Patch % Lines
...oid/libraries/matrix/test/timeline/FakeTimeline.kt 61.53% 5 Missing ⚠️
...s/impl/messagecomposer/MessageComposerPresenter.kt 77.77% 2 Missing and 2 partials ⚠️
...ine/components/event/TimelineItemAttachmentView.kt 95.16% 1 Missing and 2 partials ⚠️
...ndroid/features/messages/impl/MessagesPresenter.kt 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3902      +/-   ##
===========================================
+ Coverage    82.92%   82.95%   +0.03%     
===========================================
  Files         1785     1786       +1     
  Lines        45178    45224      +46     
  Branches      5331     5338       +7     
===========================================
+ Hits         37464    37517      +53     
+ Misses        5843     5836       -7     
  Partials      1871     1871              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bmarty bmarty force-pushed the feature/bma/editMediaCaption branch from 800d048 to ae94b44 Compare November 21, 2024 10:34
@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 21, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 21, 2024
@bmarty bmarty merged commit e8af711 into develop Nov 21, 2024
29 checks passed
@bmarty bmarty deleted the feature/bma/editMediaCaption branch November 21, 2024 13:51
@pixlwave pixlwave mentioned this pull request Dec 12, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Feature For a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Edit a media caption
3 participants