-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to set caption when uploading file and audio files, and allow adding / edit / remove caption on Event with attachment (also works on local echo) #3902
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
cbfaf01
to
800d048
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3902 +/- ##
===========================================
+ Coverage 82.92% 82.95% +0.03%
===========================================
Files 1785 1786 +1
Lines 45178 45224 +46
Branches 5331 5338 +7
===========================================
+ Hits 37464 37517 +53
+ Misses 5843 5836 -7
Partials 1871 1871 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Need to preview all the attachments now, to be able to type a caption.
800d048
to
ae94b44
Compare
|
Content
Allow to set caption when uploading file and audio files, and allow adding / edit / remove media caption on Event (also work on local echo)
Motivation and context
Closes #3859
Screenshots / GIFs
AddEditRemoveCaptionFull.mp4
Tests
Repeat the same actions when in airplane mode. The last state should be sent to the server once the network is back.
Tested devices
Checklist