Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the SDK is syncing during an incoming call so that the app can cancel the notification #3931

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 22, 2024

Content

Ensure that the SDK is syncing during an incoming call so that the application can detect if the call has been answered on another session.This is dealing with the case the application is not in foreground.

Motivation and context

Ensure the call stops ringing if answered elsewhere.

Screenshots / GIFs

On the left: Alice EW
In the middle: Bob's EW
On the right: Bob's EX

IncomingCall

Tests

  • EX is killed on Bob's device
  • Alice starts a call in her DM with Bob
  • Bob answers the call using Element Web
  • Bob's EX stops ringing

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

…plication can detect if the call has been answered on another session.

This is dealing with the case the application is not in foreground.
@bmarty bmarty requested a review from a team as a code owner November 22, 2024 18:54
@bmarty bmarty requested review from ganfra and removed request for a team November 22, 2024 18:54
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/7b9SpA

@bmarty bmarty added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 22, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.97%. Comparing base (20674dd) to head (031ed22).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
...raries/push/impl/push/OnNotifiableEventReceived.kt 0.00% 2 Missing ⚠️
.../libraries/push/impl/push/SyncOnNotifiableEvent.kt 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3931      +/-   ##
===========================================
- Coverage    82.97%   82.97%   -0.01%     
===========================================
  Files         1789     1789              
  Lines        45222    45231       +9     
  Branches      5337     5339       +2     
===========================================
+ Hits         37522    37529       +7     
- Misses        5825     5827       +2     
  Partials      1875     1875              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@fkwp
Copy link
Contributor

fkwp commented Nov 25, 2024

tested with real device and it worked:

  • Stop ringing if the caller stops the call early
  • stop ringing if you pickup the call with another device

@bmarty bmarty merged commit e347294 into develop Nov 25, 2024
29 of 30 checks passed
@bmarty bmarty deleted the feature/bma/stopIncomingElementCall branch November 25, 2024 09:07
@toger5
Copy link

toger5 commented Nov 26, 2024

@bmarty for me it still does not work if my phone is in standby.
It does work however if not in standby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants