Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : hide keyboard when TextComposer is removed from composition #3985

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Dec 2, 2024

Content

Take over #3968

Make sure the keyboard is closed when TextComposer is removed from composition.

Motivation and context

Closes #3572

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra added the PR-Bugfix For bug fix label Dec 2, 2024
@ganfra ganfra marked this pull request as ready for review December 2, 2024 20:59
@ganfra ganfra requested a review from a team as a code owner December 2, 2024 20:59
@ganfra ganfra requested review from bmarty and removed request for a team December 2, 2024 20:59
Copy link
Contributor

github-actions bot commented Dec 2, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/561NSE

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.10%. Comparing base (4bb6c24) to head (a475cb8).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
...ies/designsystem/utils/HideKeyboardWhenDisposed.kt 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3985   +/-   ##
========================================
  Coverage    83.10%   83.10%           
========================================
  Files         1806     1807    +1     
  Lines        45703    45710    +7     
  Branches      5383     5383           
========================================
+ Hits         37980    37986    +6     
  Misses        5835     5835           
- Partials      1888     1889    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

onDispose {
keyboardController?.hide()
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe extract to a common module so it can be reused?

@Composable
fun HideKeyboardWhenDisposed() {
    val keyboardController = LocalSoftwareKeyboardController.current
    DisposableEffect(Unit) {
        onDispose {
            keyboardController?.hide()
        }
    }
}

@ganfra ganfra force-pushed the feature/fga/close_keyboard_navigation branch from 69d24db to a475cb8 Compare December 3, 2024 11:12
@ganfra ganfra enabled auto-merge December 3, 2024 11:12
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 3, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 3, 2024
Copy link

sonarqubecloud bot commented Dec 3, 2024

@ganfra ganfra merged commit 57748b4 into develop Dec 3, 2024
30 checks passed
@ganfra ganfra deleted the feature/fga/close_keyboard_navigation branch December 3, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Bugfix For bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Click on notification to open chat, type on keyboard not working
2 participants