Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: knock avatars #4014

Merged
merged 5 commits into from
Dec 10, 2024
Merged

UI: knock avatars #4014

merged 5 commits into from
Dec 10, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 10, 2024

@bmarty bmarty added Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. PR-Misc For other changes labels Dec 10, 2024
@bmarty bmarty requested a review from a team as a code owner December 10, 2024 10:39
@bmarty bmarty requested review from ganfra and removed request for a team December 10, 2024 10:39
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/8diSUh

@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.09%. Comparing base (967115b) to head (177b57f).
Report is 8 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #4014   +/-   ##
========================================
  Coverage    83.08%   83.09%           
========================================
  Files         1821     1821           
  Lines        46450    46466   +16     
  Branches      5444     5445    +1     
========================================
+ Hits         38594    38610   +16     
  Misses        5946     5946           
  Partials      1910     1910

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty force-pushed the feature/bma/knockAvatars branch from 7270bc1 to 4064cad Compare December 10, 2024 10:58
@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 10, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 10, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ganfra ganfra enabled auto-merge December 10, 2024 14:45
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 10, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 10, 2024
@ganfra ganfra merged commit 8914c5a into develop Dec 10, 2024
30 checks passed
@ganfra ganfra deleted the feature/bma/knockAvatars branch December 10, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganfra ganfra ganfra approved these changes

Assignees
No one assigned
Labels
PR-Misc For other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bmarty @ganfra @ElementBot