Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update message action list #4056

Merged
merged 8 commits into from
Dec 18, 2024
Merged

Update message action list #4056

merged 8 commits into from
Dec 18, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 17, 2024

Content

Reorder some items in the message action list and add a few test.
Also create a dedicated item to edit polls and fix wrong icon used for "Remove caption"

Motivation and context

Closes #4046
Figma: https://www.figma.com/design/G1xy0HDZKJf5TCRFmKb5d5/Compound-Android-Components?node-id=1967-4558

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner December 17, 2024 13:45
@bmarty bmarty requested review from ganfra and removed request for a team December 17, 2024 13:45
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ovrbFM

@bmarty bmarty added the PR-Misc For other changes label Dec 17, 2024
@bmarty bmarty merged commit 0648cf3 into develop Dec 18, 2024
26 of 27 checks passed
@bmarty bmarty deleted the feature/bma/messageActionList branch December 18, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider swapping the "Pin" and "Edit" message options
3 participants