Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update recovery key UI #4065

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Update recovery key UI #4065

merged 3 commits into from
Dec 18, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Dec 18, 2024

Closes #4063

@bmarty bmarty requested a review from a team as a code owner December 18, 2024 15:25
@bmarty bmarty requested review from ganfra and removed request for a team December 18, 2024 15:25
@bmarty bmarty added the PR-Misc For other changes label Dec 18, 2024
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/HLaCvy

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.11%. Comparing base (21d5ff8) to head (ad2496c).
Report is 22 commits behind head on develop.

Files with missing lines Patch % Lines
...s/securebackup/impl/setup/views/RecoveryKeyView.kt 97.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4065   +/-   ##
========================================
  Coverage    83.11%   83.11%           
========================================
  Files         1872     1872           
  Lines        48707    48719   +12     
  Branches      5713     5715    +2     
========================================
+ Hits         40481    40492   +11     
- Misses        6185     6186    +1     
  Partials      2041     2041           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty merged commit 1c2be66 into develop Dec 18, 2024
30 checks passed
@bmarty bmarty deleted the feature/bma/recoveryKeyUi branch December 18, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Misc For other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Update the design of the recovery key field
3 participants