-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme override #4226
base: develop
Are you sure you want to change the base?
Theme override #4226
Conversation
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good in general, but I'm a bit worried about the changes in tokens and how they affected the preview. Can we double check those are fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't these been reversed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but we were using colors not from the theme... We need a design source for this anyway.
@amshakal can you help please? We need colors for this banner:
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit worried these items now look less like they're in a disabled state, but I guess they are using the right tokens now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think so
Quality Gate passedIssues Measures |
Content
Give ability to override theme color at build time.
Get color from ElementTheme instead of MaterialTheme when possible.
Motivation and context
Allow Element Enterprise customization.
Screenshots / GIFs
Tests
Tested devices
Checklist