Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly reports #4235

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix nightly reports #4235

wants to merge 2 commits into from

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Feb 5, 2025

First commit is just moving test classes to the correct package.

Second commit fix the test in release mode: ./gradlew :features:roomdetails:impl:testReleaseUnitTest was failing before this change because RoomAlias does not fail in release mode when the room alias is invalid.

…e there is no validation in release mode.

This is fixing the test in release mode.
@bmarty bmarty requested a review from a team as a code owner February 5, 2025 17:12
@bmarty bmarty requested review from jmartinesp and removed request for a team February 5, 2025 17:12
Copy link
Contributor

github-actions bot commented Feb 5, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/iHtGCb

Copy link

sonarqubecloud bot commented Feb 5, 2025

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.23%. Comparing base (cb549e8) to head (070fd4f).

Files with missing lines Patch % Lines
...ement/android/libraries/matrix/api/MatrixClient.kt 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4235      +/-   ##
===========================================
- Coverage    80.23%   80.23%   -0.01%     
===========================================
  Files         2045     2045              
  Lines        54182    54184       +2     
  Branches      6576     6580       +4     
===========================================
  Hits         43473    43473              
  Misses        8434     8434              
- Partials      2275     2277       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmarty bmarty added the PR-Build For changes related to build, tools, CI/CD label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Build For changes related to build, tools, CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant