Change : Room Preview

[ganfra]

Content

This PR takes care to update the JoinRoom screen aka Room Preview, it includes :

• Removing the background gradient
• Updating the loading and error states
• Managing new cases like Membership.Banned or JoinRule.Restricted
• Add the "Forget Room" action (for Membership.Banned state)

There are still a bunch of small things to fix, but I'll iterate again later.

Motivation and context

Closes #4141
Closes #4142
Figma link : https://www.figma.com/design/7TqjqdMBaPpm3IavKsMYu6/Ask-to-join-(Knocking)?node-id=4797-42334&m=dev

Screenshots / GIFs

See recorded screenshots.

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/U6QDwD

[codecov]

Codecov Report

Attention: Patch coverage is 79.80769% with 84 lines in your changes missing coverage. Please review.

Project coverage is 80.06%. Comparing base (819503b) to head (9b9e7b1).
Report is 6 commits behind head on develop.

Files with missing lines	Patch %	Lines
...roid/libraries/matrix/impl/room/RustRoomPreview.kt	0.00%	21 Missing ⚠️
...ent/android/features/joinroom/impl/JoinRoomView.kt	88.19%	17 Missing and 2 partials ⚠️
...ndroid/features/joinroom/impl/JoinRoomPresenter.kt	73.80%	5 Missing and 6 partials ⚠️
.../android/libraries/matrix/impl/RustMatrixClient.kt	0.00%	8 Missing ⚠️
...nt/android/features/joinroom/impl/di/ForgetRoom.kt	0.00%	5 Missing ⚠️
...roid/libraries/matrix/impl/room/RustRoomFactory.kt	0.00%	5 Missing ⚠️
...es/roomaliasresolver/impl/RoomAliasResolverView.kt	87.87%	3 Missing and 1 partial ⚠️
...nt/android/features/joinroom/impl/JoinRoomState.kt	89.28%	2 Missing and 1 partial ⚠️
...roid/libraries/matrix/test/room/FakeRoomPreview.kt	84.61%	2 Missing ⚠️
...ndroid/features/joinroom/impl/di/JoinRoomModule.kt	0.00%	1 Missing ⚠️
... and 5 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4250      +/-   ##
===========================================
- Coverage    80.07%   80.06%   -0.01%     
===========================================
  Files         2048     2051       +3     
  Lines        54357    54574     +217     
  Branches      6633     6666      +33     
===========================================
+ Hits         43525    43695     +170     
- Misses        8555     8594      +39     
- Partials      2277     2285       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmartinesp]

Some things I found. Since @ganfra is away at the moment I'll take over the PR and try fixing those issues.

[jmartinesp]

🎉

[jmartinesp]

Approving this after a review. I also made some changes to be able to get the banning user's name and the reason for the ban so we have feature parity with iOS.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud