Prevent crashes when computing aspect ratios on zero media width or h…

…eight
element-hq · Feb 8, 2024 · b4b9224 · b4b9224
1 parent 1304f67
commit b4b9224
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/ElementX/Sources/Services/Timeline/TimelineItems/RoomTimelineItemFactory.swift b/ElementX/Sources/Services/Timeline/TimelineItems/RoomTimelineItemFactory.swift
@@ -134,7 +134,7 @@ struct RoomTimelineItemFactory: RoomTimelineItemFactoryProtocol {
         var aspectRatio: CGFloat?
         let width = imageInfo.width.map(CGFloat.init)
         let height = imageInfo.height.map(CGFloat.init)
-        if let width, let height {
+        if let width, let height, width > 0, height > 0 {
             aspectRatio = width / height
         }
 
@@ -488,7 +488,7 @@ struct RoomTimelineItemFactory: RoomTimelineItemFactoryProtocol {
         let height = messageContent.info?.height.map(CGFloat.init)
 
         var aspectRatio: CGFloat?
-        if let width, let height {
+        if let width, let height, width > 0, height > 0 {
             aspectRatio = width / height
         }
 
@@ -508,7 +508,7 @@ struct RoomTimelineItemFactory: RoomTimelineItemFactoryProtocol {
         let height = messageContent.info?.height.map(CGFloat.init)
 
         var aspectRatio: CGFloat?
-        if let width, let height {
+        if let width, let height, width > 0, height > 0 {
             aspectRatio = width / height
         }