-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry send and cancel send for failed to send messages #1088
Conversation
3a78631
to
41a724f
Compare
Generated by 🚫 Danger Swift against b5124a6 |
This all looks good, but can you add the header text? |
It should say 'Your message failed to send.' |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1088 +/- ##
===========================================
- Coverage 44.58% 44.51% -0.08%
===========================================
Files 384 385 +1
Lines 24241 24356 +115
Branches 12823 12877 +54
===========================================
+ Hits 10809 10843 +34
- Misses 13142 13224 +82
+ Partials 290 289 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@callumu |
Kudos, SonarCloud Quality Gate passed!
|
Okay cool this looks good 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too 👏
Some screen recording of both behaviours here:
https://github.com/vector-im/element-x-ios/assets/34335419/c5e59564-6da1-42f5-80cd-f615d2a8bd80
https://github.com/vector-im/element-x-ios/assets/34335419/63e1ba2d-cc32-452b-bd88-c3b3fa814ba0