Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry send and cancel send for failed to send messages #1088

Merged
merged 4 commits into from
Jun 16, 2023

Conversation

@Velin92 Velin92 requested a review from a team as a code owner June 15, 2023 16:58
@Velin92 Velin92 requested review from stefanceriu and callumu and removed request for a team June 15, 2023 16:58
@Velin92 Velin92 force-pushed the mauroromito/retry_send branch from 3a78631 to 41a724f Compare June 15, 2023 16:58
@github-actions
Copy link

github-actions bot commented Jun 15, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

ElementX/Sources/Screens/RoomScreen/RoomScreenViewModel.swift#L335 - SwiftLint rule 'function_body_length' did not trigger a violation in the disabled region. Please remove the disable command. (superfluous_disable_command)

Generated by 🚫 Danger Swift against b5124a6

@Velin92 Velin92 linked an issue Jun 15, 2023 that may be closed by this pull request
@callumu
Copy link

callumu commented Jun 15, 2023

This all looks good, but can you add the header text?

@callumu
Copy link

callumu commented Jun 15, 2023

It should say 'Your message failed to send.'

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 24.63% and project coverage change: -0.08 ⚠️

Comparison is base (163e38b) 44.58% compared to head (b5124a6) 44.51%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1088      +/-   ##
===========================================
- Coverage    44.58%   44.51%   -0.08%     
===========================================
  Files          384      385       +1     
  Lines        24241    24356     +115     
  Branches     12823    12877      +54     
===========================================
+ Hits         10809    10843      +34     
- Misses       13142    13224      +82     
+ Partials       290      289       -1     
Flag Coverage Δ
unittests 23.66% <24.63%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../Sources/Other/Extensions/ConfirmationDialog.swift 0.00% <0.00%> (ø)
.../Sources/Screens/RoomScreen/RoomScreenModels.swift 70.83% <0.00%> (-3.08%) ⬇️
...X/Sources/Screens/RoomScreen/View/RoomScreen.swift 50.83% <0.00%> (-3.64%) ⬇️
...een/View/Style/TimelineItemBubbledStylerView.swift 30.43% <0.00%> (-1.51%) ⬇️
...en/View/Supplementary/TimelineItemStatusView.swift 0.00% <0.00%> (ø)
ElementX/Sources/Services/Room/RoomProxy.swift 0.00% <0.00%> (ø)
...entX/Sources/Services/Room/RoomProxyProtocol.swift 68.42% <ø> (ø)
...melineItemContent/RoomTimelineItemProperties.swift 100.00% <ø> (ø)
.../Sources/Services/Timeline/TimelineItemProxy.swift 0.00% <0.00%> (ø)
...meline/TimelineItems/RoomTimelineItemFactory.swift 1.54% <0.00%> (-0.04%) ⬇️
... and 2 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Velin92
Copy link
Member Author

Velin92 commented Jun 16, 2023

It should say 'Your message failed to send.'

@callumu
oh yeah my bad, forgot to make the title always visible for the confirmation dialog, here it is a screenshot with the title:
simulator_screenshot_EDCC08F4-7CA2-477B-B193-86374DA8EC9E

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@callumu
Copy link

callumu commented Jun 16, 2023

It should say 'Your message failed to send.'

@callumu oh yeah my bad, forgot to make the title always visible for the confirmation dialog, here it is a screenshot with the title: simulator_screenshot_EDCC08F4-7CA2-477B-B193-86374DA8EC9E

Okay cool this looks good 👍

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too 👏

@Velin92 Velin92 merged commit ac41704 into develop Jun 16, 2023
@Velin92 Velin92 deleted the mauroromito/retry_send branch June 16, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for retrying messages that failed to send
3 participants