Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element call tweaks #1791

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Element call tweaks #1791

merged 3 commits into from
Sep 25, 2023

Conversation

stefanceriu
Copy link
Member

  • Only allow https call links to be passed through the custom app scheme
  • Pass in custom call URL query parameters
  • Add more tests for the AppRouteURLParser

@stefanceriu stefanceriu requested a review from a team as a code owner September 25, 2023 06:19
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team September 25, 2023 06:19
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 2aa0b72

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage: 39.18% and project coverage change: +0.01% 🎉

Comparison is base (bc1910e) 71.23% compared to head (2aa0b72) 71.24%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1791      +/-   ##
===========================================
+ Coverage    71.23%   71.24%   +0.01%     
===========================================
  Files          435      435              
  Lines        29532    29575      +43     
  Branches     14554    14573      +19     
===========================================
+ Hits         21038    21072      +34     
- Misses        7967     7976       +9     
  Partials       527      527              
Flag Coverage Δ
unittests 54.65% <39.18%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ces/Screens/Other/GenericCallLinkCoordinator.swift 0.00% <0.00%> (ø)
...meline/TimelineItems/RoomTimelineItemFactory.swift 20.99% <0.00%> (ø)
...Messages/VoiceMessages/VoiceRoomPlaybackView.swift 47.65% <30.43%> (+4.55%) ⬆️
...Messages/VoiceMessages/VoiceRoomTimelineView.swift 60.97% <50.00%> (ø)
...ms/Items/Messages/VoiceMessages/WaveformView.swift 87.50% <80.95%> (-0.26%) ⬇️
...ntX/Sources/Application/Navigation/AppRoutes.swift 75.86% <100.00%> (+13.36%) ⬆️
...ces/Screens/RoomScreen/View/SwipeRightAction.swift 85.57% <100.00%> (+2.39%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanceriu stefanceriu merged commit 356a316 into develop Sep 25, 2023
@stefanceriu stefanceriu deleted the stefan/elementCallTweaks branch September 25, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants