Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an animation glitch when signing in on iOS 16. #2098

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

pixlwave
Copy link
Member

Fixes #1807 which only seems to occur on iOS 16. Maybe building with Xcode 15 will also back-deploy the fix, but this seems good enough for now (there is a small chance that the individual cell animations could become out of sync as they're not coordinated this way).

@pixlwave pixlwave requested a review from a team as a code owner November 16, 2023 16:39
@pixlwave pixlwave requested review from stefanceriu and removed request for a team November 16, 2023 16:39
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against b47b8b4

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0831c89) 69.86% compared to head (b47b8b4) 69.86%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2098   +/-   ##
========================================
  Coverage    69.86%   69.86%           
========================================
  Files          522      522           
  Lines        36379    36379           
  Branches     17586    17586           
========================================
+ Hits         25415    25416    +1     
+ Misses       10322    10320    -2     
- Partials       642      643    +1     
Flag Coverage Δ
unittests 57.24% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 2274262 into develop Nov 17, 2023
@pixlwave pixlwave deleted the doug/stop-the-accordian branch November 17, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accordian like room list animation while syncing
2 participants