Fix a rendering issue when a message starts with a list (#1915) #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimau
requested review from
stefanceriu and
Velin92
and removed request for
a team
Generated by 🚫 Danger Swift against 86eb724 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2152 +/- ##
===========================================
- Coverage 71.39% 71.33% -0.07%
===========================================
Files 515 515
Lines 35185 35232 +47
Branches 16945 16946 +1
===========================================
+ Hits 25122 25131 +9
- Misses 9443 9480 +37
- Partials 620 621 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nimau
force-pushed
the
nicolas/1915-markdown-list
branch
from
cfac8e3 to
b73d8cd
Compare
stefanceriu
reviewed
Nov 23, 2023
Velin92
reviewed
Nov 24, 2023
Velin92
reviewed
Nov 24, 2023
ElementX/Sources/Screens/RoomScreen/View/Timeline/FormattedBodyText.swift
Show resolved
Hide resolved
Velin92
approved these changes
Nov 27, 2023
Velin92
approved these changes
Nov 27, 2023
nimau
force-pushed
the
nicolas/1915-markdown-list
branch
from
265a85c to
b4eb7aa
Compare
nimau
force-pushed
the
nicolas/1915-markdown-list
branch
from
b4eb7aa to
86eb724
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the display of messages when they begin with a list (#1915)
Before:
After:
