-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include changelog.d and other common files in Xcode project #219
Conversation
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/PMCcqi |
Codecov ReportBase: 11.79% // Head: 11.79% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #219 +/- ##
========================================
Coverage 11.79% 11.79%
========================================
Files 213 213
Lines 14359 14359
Branches 6974 6974
========================================
Hits 1693 1693
Misses 12623 12623
Partials 43 43
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I like the idea I don't love having all these files pile up on top of our project navigator. Is there a way we can drop them inside a miscellaneous folder or something?
Yeah, sure I can do that. I'd also be fine with only including the |
I'm not actually sure you can actually do that looking at the specs. If that's the case let's just merge is at as it. |
Generated by 🚫 Danger Swift against cdfc9f7 |
Hm, looks like you're right. The To limit the pain, I removed the markdown files for now and only included the |
Kudos, SonarCloud Quality Gate passed!
|
Fixes: #218
Pull Request Checklist
UI changes have been tested with: