Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include changelog.d and other common files in Xcode project #219

Merged
merged 5 commits into from
Sep 28, 2022

Conversation

Johennes
Copy link
Contributor

Fixes: #218

Pull Request Checklist

UI changes have been tested with:

  • iPhone and iPad simulators in portrait and landscape orientations.
  • Dark mode enabled and disabled.
  • Various sizes of dynamic type.
  • Voiceover enabled.

@Johennes Johennes requested review from a team and stefanceriu and removed request for a team September 27, 2022 19:23
@github-actions
Copy link

github-actions bot commented Sep 27, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/PMCcqi

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 11.79% // Head: 11.79% // No change to project coverage 👍

Coverage data is based on head (e0cc08f) compared to base (e618d9b).
Patch has no changes to coverable lines.

❗ Current head e0cc08f differs from pull request most recent head cdfc9f7. Consider uploading reports for the commit cdfc9f7 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #219   +/-   ##
========================================
  Coverage    11.79%   11.79%           
========================================
  Files          213      213           
  Lines        14359    14359           
  Branches      6974     6974           
========================================
  Hits          1693     1693           
  Misses       12623    12623           
  Partials        43       43           
Impacted Files Coverage Δ
ElementX/Sources/Other/Tests.swift 100.00% <0.00%> (ø)
...es/Other/SwiftUI/Animation/ElementAnimations.swift 44.44% <0.00%> (ø)
...or/WeakDictionary/WeakDictionaryKeyReference.swift
...endor/WeakDictionary/WeakDictionaryReference.swift
...Sources/Vendor/WeakDictionary/WeakDictionary.swift
...rces/Vendor/WeakDictionary/WeakKeyDictionary.swift
...er/WeakDictionary/WeakDictionaryKeyReference.swift 0.00% <0.00%> (ø)
...Other/WeakDictionary/WeakDictionaryReference.swift 100.00% <0.00%> (ø)
...urces/Other/WeakDictionary/WeakKeyDictionary.swift 0.00% <0.00%> (ø)
.../Sources/Other/WeakDictionary/WeakDictionary.swift 26.86% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I like the idea I don't love having all these files pile up on top of our project navigator. Is there a way we can drop them inside a miscellaneous folder or something?

@Johennes
Copy link
Contributor Author

Yeah, sure I can do that. I'd also be fine with only including the changelog.d folder for now. I only added the others because element-ios also included these. But I don't think they're as widely used as the changelog folder.

@stefanceriu
Copy link
Member

sure I can do that

I'm not actually sure you can actually do that looking at the specs. If that's the case let's just merge is at as it.

@stefanceriu stefanceriu enabled auto-merge (rebase) September 28, 2022 08:08
@github-actions
Copy link

github-actions bot commented Sep 28, 2022

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against cdfc9f7

@Johennes
Copy link
Contributor Author

I'm not actually sure you can actually do that looking at the specs. If that's the case let's just merge is at as it.

Hm, looks like you're right. The fileGroups property doesn't allow any further options. So unless we want to move things around on the file system, all the items will have to be at the top level.

To limit the pain, I removed the markdown files for now and only included the changelog.d folder which, I think, is that one that is accessed most often.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stefanceriu stefanceriu merged commit 40d80e1 into develop Sep 28, 2022
@stefanceriu stefanceriu deleted the johannes/changelog.d-in-project branch September 28, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add changelog.d folder in Xcode project
2 participants