Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poll title is displayed multiline when creating a poll #2225

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Poll title is displayed multiline when creating a poll #2225

merged 4 commits into from
Dec 11, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Dec 11, 2023 •
edited
Loading

fixes #2215
Simulator Screenshot - iPhone 14 - 2023-12-11 at 16 45 15

@Velin92 Velin92 requested a review from a team as a code owner December 11, 2023 15:44
@Velin92 Velin92 requested review from pixlwave and removed request for a team December 11, 2023 15:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2023 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 9361e87

stefanceriu
stefanceriu approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@Velin92 Velin92 enabled auto-merge (squash) December 11, 2023 15:53
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Velin92 Velin92 merged commit deb109f into develop Dec 11, 2023
5 checks passed
@Velin92 Velin92 deleted the mauroromito/poll_multiline branch December 11, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

@pixlwave pixlwave Awaiting requested review from pixlwave pixlwave is a code owner automatically assigned from element-hq/element-x-ios-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Polls: Show a multiline input field when creating a long poll
2 participants
@Velin92 @stefanceriu