Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Grey dot appears when you have unread messages that does not trigger a notification #2371

Merged
merged 8 commits into from
Jan 23, 2024
Merged

Fix: Grey dot appears when you have unread messages that does not trigger a notification #2371

merged 8 commits into from
Jan 23, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jan 23, 2024 •
edited
Loading

Grey dot is back

Simulator Screenshot - iPhone 14 - 2024-01-23 at 13 13 59

@Velin92 Velin92 requested a review from a team as a code owner January 23, 2024 12:14
@Velin92 Velin92 requested review from stefanceriu and removed request for a team January 23, 2024 12:14
@Velin92 Velin92 changed the title Grey dot is back Fix: Grey dot appears when you have unread messages that do not trigger a notification Jan 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.
⚠️

ElementX/Sources/Screens/HomeScreen/HomeScreenViewModel.swift#L336 - Line should be 250 characters or less: currently 257 characters (line_length)
⚠️

ElementX/Sources/Services/Room/RoomSummary/RoomSummaryDetails.swift#L38 - Line should be 250 characters or less: currently 272 characters (line_length)

Generated by 🚫 Danger Swift against 33bb5c2

@Velin92 Velin92 enabled auto-merge (squash) January 23, 2024 12:20
@Velin92 Velin92 changed the title Fix: Grey dot appears when you have unread messages that do not trigger a notification Fix: Grey dot appears when you have unread messages that does not trigger a notification Jan 23, 2024
@Velin92 Velin92 requested a review from pixlwave January 23, 2024 12:43
pixlwave
pixlwave approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

ElementX/Sources/Screens/HomeScreen/HomeScreenModels.swift Outdated Show resolved Hide resolved
ElementX/Sources/Services/Room/RoomSummary/MockRoomSummaryProvider.swift Show resolved Hide resolved
ElementX/Sources/Screens/HomeScreen/View/HomeScreenRoomCell.swift Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Velin92 Velin92 merged commit 550db5e into develop Jan 23, 2024
5 checks passed
@Velin92 Velin92 deleted the mauroromito/grey_dot_fix branch January 23, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu left review comments

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Velin92 @stefanceriu @pixlwave