Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a Client in AuthenticationService now that the Rust one has been removed. #2954

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jun 21, 2024

Rust's AuthenticationService has been removed in matrix-org/matrix-rust-sdk#3594. This PR moves what was very simple logic that called into a Client directly into our app-side AuthenticationService.

Can be reviewed commit-by-commit.

Copy link

github-actions bot commented Jun 21, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against e38d5d4

@pixlwave pixlwave force-pushed the doug/native-auth-service branch from 82649fd to d5d8f67 Compare June 24, 2024 10:07
@pixlwave pixlwave marked this pull request as ready for review June 24, 2024 10:07
@pixlwave pixlwave requested a review from a team as a code owner June 24, 2024 10:07
@pixlwave pixlwave requested review from Velin92 and removed request for a team June 24, 2024 10:07
@pixlwave pixlwave force-pushed the doug/native-auth-service branch from d5d8f67 to e38d5d4 Compare June 24, 2024 10:11
Copy link

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 1.06383% with 93 lines in your changes missing coverage. Please review.

Project coverage is 78.23%. Comparing base (fc0573a) to head (e38d5d4).

Files Patch % Lines
...ervices/Authentication/AuthenticationService.swift 0.00% 38 Missing ⚠️
...mentX/Sources/Other/Extensions/ClientBuilder.swift 0.00% 20 Missing ⚠️
ElementX/Sources/Application/AppCoordinator.swift 0.00% 9 Missing ⚠️
...X/Sources/Services/QRCode/QRCodeLoginService.swift 0.00% 8 Missing ⚠️
...s/Authentication/OIDCAuthenticationPresenter.swift 0.00% 6 Missing ⚠️
...ources/Services/UserSession/UserSessionStore.swift 0.00% 4 Missing ⚠️
NSE/Sources/Other/NSEUserSession.swift 0.00% 4 Missing ⚠️
...ntication/LoginScreen/LoginScreenCoordinator.swift 0.00% 1 Missing ⚠️
...ctionScreen/ServerSelectionScreenCoordinator.swift 0.00% 1 Missing ⚠️
...SoftLogoutScreen/SoftLogoutScreenCoordinator.swift 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2954      +/-   ##
===========================================
- Coverage    78.45%   78.23%   -0.22%     
===========================================
  Files          691      694       +3     
  Lines        54047    54172     +125     
===========================================
- Hits         42405    42384      -21     
- Misses       11642    11788     +146     
Flag Coverage Δ
unittests 68.82% <1.06%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 3465ea4 into develop Jun 24, 2024
9 checks passed
@pixlwave pixlwave deleted the doug/native-auth-service branch June 24, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants