-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RTE to 2.37.7 #3064
Update RTE to 2.37.7 #3064
Conversation
Generated by 🚫 Danger Swift against db5c12b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can get rid of this too:
element-x-ios/ElementX/SupportingFiles/target.yml
Lines 177 to 189 in 7fbdc2c
- name: 🔧 Fix the Rich Text Editor | |
runOnlyWhenInstalling: false | |
basedOnDependencyAnalysis: false | |
shell: /bin/sh | |
script: | | |
# The RTE XCFramework contains .frameworks instead of static libs. For some reason Xcode embeds the binary, but also | |
# an empty framework containing a stub binary. This stub binary is generated for our app and so its version mismatches | |
# the one declared by the XCFramework's Info.plist file (and we can't match it because of Element iOS). ASC doesn't like this. | |
if [ "$CONFIGURATION" == "Release" ]; then | |
# On the other hand local device builds detect a signature change, so only do this when in Release mode. | |
# Not ideal but helps us most of the time and we can remove this run phase locally if needed. | |
/usr/libexec/PlistBuddy -c "Set :MinimumOSVersion ${IPHONEOS_DEPLOYMENT_TARGET}" ${BUILT_PRODUCTS_DIR}/ElementX.app/Frameworks/WysiwygComposerFFI.framework/Info.plist | |
fi |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3064 +/- ##
===========================================
+ Coverage 77.33% 77.38% +0.04%
===========================================
Files 699 699
Lines 54408 54408
===========================================
+ Hits 42079 42103 +24
+ Misses 12329 12305 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aa7d74f
to
db5c12b
Compare
|
No difference in terms of features, but this new version builds the XCFramework correctly