Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RTE to 2.37.7 #3064

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Update RTE to 2.37.7 #3064

merged 1 commit into from
Jul 18, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jul 18, 2024

No difference in terms of features, but this new version builds the XCFramework correctly

@Velin92 Velin92 requested a review from a team as a code owner July 18, 2024 15:36
@Velin92 Velin92 requested review from pixlwave and removed request for a team July 18, 2024 15:36
@Velin92 Velin92 added the pr-misc for other changes label Jul 18, 2024
Copy link

github-actions bot commented Jul 18, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against db5c12b

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get rid of this too:

- name: 🔧 Fix the Rich Text Editor
runOnlyWhenInstalling: false
basedOnDependencyAnalysis: false
shell: /bin/sh
script: |
# The RTE XCFramework contains .frameworks instead of static libs. For some reason Xcode embeds the binary, but also
# an empty framework containing a stub binary. This stub binary is generated for our app and so its version mismatches
# the one declared by the XCFramework's Info.plist file (and we can't match it because of Element iOS). ASC doesn't like this.
if [ "$CONFIGURATION" == "Release" ]; then
# On the other hand local device builds detect a signature change, so only do this when in Release mode.
# Not ideal but helps us most of the time and we can remove this run phase locally if needed.
/usr/libexec/PlistBuddy -c "Set :MinimumOSVersion ${IPHONEOS_DEPLOYMENT_TARGET}" ${BUILT_PRODUCTS_DIR}/ElementX.app/Frameworks/WysiwygComposerFFI.framework/Info.plist
fi

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.38%. Comparing base (7fbdc2c) to head (aa7d74f).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3064      +/-   ##
===========================================
+ Coverage    77.33%   77.38%   +0.04%     
===========================================
  Files          699      699              
  Lines        54408    54408              
===========================================
+ Hits         42079    42103      +24     
+ Misses       12329    12305      -24     
Flag Coverage Δ
unittests 68.58% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 force-pushed the mauroromito/update_rte_2_37_7 branch from aa7d74f to db5c12b Compare July 18, 2024 16:28
@Velin92 Velin92 merged commit 86ce3de into develop Jul 18, 2024
4 checks passed
@Velin92 Velin92 deleted the mauroromito/update_rte_2_37_7 branch July 18, 2024 16:28
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants