Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group image and video metadata in specialised structs #3518

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu requested a review from pixlwave November 15, 2024 10:12
@stefanceriu stefanceriu requested a review from a team as a code owner November 15, 2024 10:12
Copy link

github-actions bot commented Nov 15, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against acf821c

Copy link

codecov bot commented Nov 15, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
857 1 856 0
View the top 1 failed tests by shortest run time
PreviewTests test_roomDetailsEditScreen()
Stack Traces | 2.03s run time
failed - Snapshot "Editable" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_roomDetailsEditScreen-iPhone-16-pseudo.Editable.png"
@+
"file:.../tmp/PreviewTests/test_roomDetailsEditScreen-iPhone-16-pseudo.Editable.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.8477783 is less than required 1.0
The lowest perceptual color precision 0.016250014 is less than required 0.98 (.../PreviewTests/Sources/PreviewTests.swift:84)

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👏

Comment on lines 21 to 22
.timelineMediaFrame(height: timelineItem.content.thumbnailInfo?.size?.height,
aspectRatio: timelineItem.content.thumbnailInfo?.aspectRatio)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these ?? videoInfo?.height/aspectRatio?

Copy link
Member

@pixlwave pixlwave Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mixed about these being called …InfoProxy given they don't wrap an underlying rust media info. But then they wrap a media source proxy. Not actionable, just a comment :)

@stefanceriu stefanceriu added the pr-misc for other changes label Nov 15, 2024
@stefanceriu stefanceriu merged commit ef288a9 into develop Nov 15, 2024
7 checks passed
@stefanceriu stefanceriu deleted the stefan/imageInfo branch November 15, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants