-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group image and video metadata in specialised structs #3518
Conversation
Generated by 🚫 Danger Swift against acf821c |
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👏
ElementX/Sources/Screens/Timeline/View/TimelineItemViews/StickerRoomTimelineView.swift
Outdated
Show resolved
Hide resolved
.timelineMediaFrame(height: timelineItem.content.thumbnailInfo?.size?.height, | ||
aspectRatio: timelineItem.content.thumbnailInfo?.aspectRatio) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these ?? videoInfo?.height
/aspectRatio
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm mixed about these being called …InfoProxy
given they don't wrap an underlying rust media info. But then they wrap a media source proxy. Not actionable, just a comment :)
|
No description provided.