Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compound iOS #3532

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Update compound iOS #3532

merged 2 commits into from
Nov 18, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 18, 2024

No description provided.

@Velin92 Velin92 added the pr-misc for other changes label Nov 18, 2024
@Velin92 Velin92 requested a review from a team as a code owner November 18, 2024 18:04
@Velin92 Velin92 requested review from stefanceriu and removed request for a team November 18, 2024 18:04
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

github-actions bot commented Nov 18, 2024

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 1bc10e7

@Velin92 Velin92 enabled auto-merge (rebase) November 18, 2024 18:09
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.66%. Comparing base (dc05637) to head (1bc10e7).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3532      +/-   ##
===========================================
- Coverage    78.67%   78.66%   -0.02%     
===========================================
  Files          752      752              
  Lines        62880    62880              
===========================================
- Hits         49473    49463      -10     
- Misses       13407    13417      +10     
Flag Coverage Δ
unittests 69.64% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 disabled auto-merge November 18, 2024 18:26
@Velin92 Velin92 enabled auto-merge (squash) November 18, 2024 18:26
@Velin92 Velin92 merged commit 18cbbe4 into develop Nov 18, 2024
7 checks passed
@Velin92 Velin92 deleted the mauroromito/update_compound_ios branch November 18, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants