Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the DesignKit package to the project. #64

Merged
merged 6 commits into from
Jun 9, 2022
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented May 27, 2022

Following on from #57, this PR adds the package to the project and uses it in the login screen. I've added it locally using a path and Xcodegen puts it in a Packages group which is nice. Also adds:

  • An ElementTextFieldStyle that uses the BorderedInputFieldStyle and adds a header, footer and focus state.
  • Static access for all of the SwiftUI styles.

I've applied the styles to the login screen as part of this PR:

Simulator Screen Shot - iPod touch (7th generation) - 2022-06-08 at 18 59 00

@github-actions
Copy link

github-actions bot commented May 27, 2022

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against 6796f56

@github-actions
Copy link

github-actions bot commented May 27, 2022

Changes in 64 (2022-06-09)

✨ Features

  • Implement rageshake service. (#23)
  • Add filtering for rooms by name. (#26)
  • DesignKit: Add initial implementation of DesignKit to the repo as a Swift package. (#43)

🙌 Improvements

  • DesignKit: Add DesignKit to the ElementX project and style the login screen with it. (#43)

🐛 Bugfixes

  • ElementInfoPlist: Use custom template for Info.plist. (#71)

🧱 Build

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/qXoH5G

@pixlwave pixlwave force-pushed the doug/43_designkit branch from 359d30e to 95204fa Compare May 27, 2022 17:24
@pixlwave pixlwave force-pushed the doug/43_designkit branch from fb9cda3 to efddbd0 Compare June 8, 2022 17:23
@pixlwave pixlwave force-pushed the doug/43_designkit branch from efddbd0 to b6def67 Compare June 8, 2022 17:24
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2022

Codecov Report

Merging #64 (6796f56) into develop (7a45837) will increase coverage by 1.68%.
The diff coverage is 33.68%.

@@             Coverage Diff             @@
##           develop      #64      +/-   ##
===========================================
+ Coverage    14.39%   16.07%   +1.68%     
===========================================
  Files          111      121      +10     
  Lines         8866     9293     +427     
  Branches      4556     4690     +134     
===========================================
+ Hits          1276     1494     +218     
- Misses        7558     7752     +194     
- Partials        32       47      +15     
Impacted Files Coverage Δ
...nKit/Sources/Buttons/ElementGhostButtonStyle.swift 0.00% <0.00%> (ø)
DesignKit/Sources/Shapes/RoundedCornerShape.swift 0.00% <0.00%> (ø)
...ources/Screens/LoginScreen/LoginScreenModels.swift 0.00% <0.00%> (ø)
...Kit/Sources/TextFields/ElementTextFieldStyle.swift 37.28% <37.28%> (ø)
...t/Sources/TextFields/BorderedInputFieldStyle.swift 50.00% <50.00%> (ø)
...Kit/Sources/Buttons/ElementActionButtonStyle.swift 43.63% <62.50%> (ø)
...Sources/Screens/LoginScreen/View/LoginScreen.swift 65.85% <71.42%> (-6.57%) ⬇️
DesignKit/Sources/Fonts/ElementUIFonts.swift 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a45837...6796f56. Read the comment docs.

@pixlwave pixlwave marked this pull request as ready for review June 8, 2022 17:39
@pixlwave pixlwave requested review from a team and ismailgulek and removed request for a team June 8, 2022 17:39
@pixlwave pixlwave force-pushed the doug/43_designkit branch from 987f2ab to 6f60585 Compare June 8, 2022 17:42
Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of comments.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pixlwave pixlwave requested a review from ismailgulek June 9, 2022 12:48
Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pixlwave pixlwave merged commit 596cf2d into develop Jun 9, 2022
@pixlwave pixlwave deleted the doug/43_designkit branch June 9, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants