-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the DesignKit package to the project. #64
Conversation
Generated by 🚫 Danger Swift against 6796f56 |
Changes in 64 (2022-06-09)✨ Features
🙌 Improvements
🐛 Bugfixes
🧱 Build 📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/qXoH5G |
359d30e
to
95204fa
Compare
fb9cda3
to
efddbd0
Compare
efddbd0
to
b6def67
Compare
Codecov Report
@@ Coverage Diff @@
## develop #64 +/- ##
===========================================
+ Coverage 14.39% 16.07% +1.68%
===========================================
Files 111 121 +10
Lines 8866 9293 +427
Branches 4556 4690 +134
===========================================
+ Hits 1276 1494 +218
- Misses 7558 7752 +194
- Partials 32 47 +15
Continue to review full report at Codecov.
|
987f2ab
to
6f60585
Compare
ElementX.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a couple of comments.
ElementX.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Following on from #57, this PR adds the package to the project and uses it in the login screen. I've added it locally using a path and Xcodegen puts it in a
Packages
group which is nice. Also adds:ElementTextFieldStyle
that uses theBorderedInputFieldStyle
and adds a header, footer and focus state.I've applied the styles to the login screen as part of this PR: