Remote Push Notifications can now be decrypted #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against f910d2e |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #854 +/- ##
========================================
Coverage 50.96% 50.96%
========================================
Files 319 319
Lines 18880 18883 +3
Branches 10695 10696 +1
========================================
+ Hits 9622 9624 +2
+ Misses 8983 8982 -1
- Partials 275 277 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ElementX/Sources/Services/Notification/Proxy/NotificationItemProxy.swift
Show resolved
Hide resolved
pixlwave
approved these changes
May 5, 2023
ElementX/Sources/Services/Notification/Proxy/NotificationItemProxy.swift
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote pushes can now be decrypted.
NOTE: This only works if the current keys are valid, working on the Rust side to find a way to do one single sliding sync to refresh keys