don't leak timeline when an error is thrown while opening it

or you are just stuck with "not dealing with race" errors until refresh
element-hq · Jun 2, 2021 · d965d57 · d965d57
1 parent 0c4c018
commit d965d57
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/src/matrix/room/BaseRoom.js b/src/matrix/room/BaseRoom.js
@@ -404,10 +404,16 @@ export class BaseRoom extends EventEmitter {
                 clock: this._platform.clock,
                 logger: this._platform.logger,
             });
-            if (this._roomEncryption) {
-                this._timeline.enableEncryption(this._decryptEntries.bind(this, DecryptionSource.Timeline));
+            try {
+                if (this._roomEncryption) {
+                    this._timeline.enableEncryption(this._decryptEntries.bind(this, DecryptionSource.Timeline));
+                }
+                await this._timeline.load(this._user, this.membership, log);
+            } catch (err) {
+                // this also clears this._timeline in the closeCallback
+                this._timeline.dispose();
+                throw err;
             }
-            await this._timeline.load(this._user, this.membership, log);
             return this._timeline;
         });
     }