Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO Login #93

Closed
ptman opened this issue Sep 14, 2020 · 6 comments
Closed

SSO Login #93

ptman opened this issue Sep 14, 2020 · 6 comments
Assignees
Labels
feature New feature or request

Comments

@ptman
Copy link

ptman commented Sep 14, 2020

SAML / OpenID Connect login support

@bwindels
Copy link
Contributor

Hey, thanks for filing an issue, but I would rather not have a feature request issue in here for every missing feature that is not on the immediate roadmap, so closing this for now.

@bwindels
Copy link
Contributor

Probably best to raise and discuss feature requests in #hydrogen:matrix.org come to think of it.

@bwindels bwindels reopened this Mar 8, 2021
@bwindels bwindels added feature New feature or request good first issue Good for newcomers labels Mar 8, 2021
@bwindels
Copy link
Contributor

bwindels commented Mar 8, 2021

Also see https://matrix.org/docs/guides/sso-for-client-developers

@tawfiek
Copy link
Contributor

tawfiek commented Mar 18, 2021

As discussed with @bwindels

He suggest :

Adding a method startLogin(server) to SessionContainer that returns a Login object to which the response from the server is passed. Depending on the flows, it could have an sso property and password property with objects that have methods for those specific login mechanisms

And for UX and Component structure, we came out with two suggestions :

  • 1st
    Make the current LoginView is the root of the application which takes the homeserver URL Then load buttons of supported login methods that linked with individual view for every method.
LoginView
  homeserver field
  if supported: PasswordLoginView
  if suppoted: SSOLoginView
  • 2nd
    Make another parent component for the current LoginView called for example ClientConfig that takes homeserver as a user input gets the supported methods and render LoginView shows all supported login options just like in Element web.
ClientConfig
    homeserver field
    set state
    LoginView

@bwindels bwindels removed the good first issue Good for newcomers label Mar 23, 2021
@bwindels
Copy link
Contributor

bwindels commented Mar 23, 2021

Was a bit overly optimistic of me to mark this as a good-first-issue, the changes are quite involved and there isn't a lot of documentation to work with.

@bwindels
Copy link
Contributor

I have made some notes on how I expect the feature should work on https://github.com/vector-im/hydrogen-web/blob/master/doc/impl-thoughts/SSO.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants