Add SSO functionality #282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwindels
reviewed
Mar 19, 2021
| ]), | ||
| t.if( | ||
| (vm) => vm.error, | ||
| t.createTemplate((t) => |
There was a problem hiding this comment.
heads up I've removed createTemplate in #280, you can now just do t.if(vm => vm.condition, t => t.div())
…uest the loginFlows" This reverts commit 192232c.
- Use SessionLoadView inside LoginViewModal to load login flows - add new LoadStatus in session container to indecates in login flows loaded - use the new state to show a consistent label into sessioLoadView
bwindels
reviewed
Mar 22, 2021
| * @param {String} homeServer - the homeserver url | ||
| */ | ||
| _requestLoginFlows (homeServer) { | ||
| this._loadViewModel = this.track(new SessionLoadViewModel({ |
There was a problem hiding this comment.
Loading the login flows should not set the load view model. The load view model is for once you are logging in, it show "fetching your conversations from the server", etc ... It would be nice to have a spinner though, so you may want to set a queryingHomeserver flag or something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.