Fix develop server breaking due to import syntax #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwindels
reviewed
Aug 1, 2022
| import pkg from "off-color"; | ||
| const {offColor} = pkg; | ||
| import * as pkg from "off-color"; | ||
| const offColor = pkg.offColor ?? pkg.default.offColor; |
There was a problem hiding this comment.
I wonder if this would fix the tsc error?
Suggested change
| const offColor = pkg.offColor ?? pkg.default.offColor; | |
| const offColor = pkg.offColor ?? pkg.default?.offColor; |
MidhunSureshR
force-pushed
the
fix-dev-server-1
branch
from
1e76257 to
8325974
Compare
bwindels
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.