Fix new media APIs when using synapse.app.media_repository (#17420)

Co-authored-by: Andrew Morgan <[email protected]>
element-hq · Jul 9, 2024 · 22fbc5b · 22fbc5b
1 parent 62d8b03
commit 22fbc5b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/changelog.d/17420.bugfix b/changelog.d/17420.bugfix
@@ -0,0 +1 @@
+Fix bug where using `synapse.app.media_repository` worker configuration would break the new media endpoints.
diff --git a/synapse/federation/transport/server/__init__.py b/synapse/federation/transport/server/__init__.py
@@ -321,7 +321,7 @@ def register_servlets(
                 servletclass == FederationMediaDownloadServlet
                 or servletclass == FederationMediaThumbnailServlet
             ):
-                if not hs.config.server.enable_media_repo:
+                if not hs.config.media.can_load_media_repo:
                     continue
 
             servletclass(

diff --git a/synapse/rest/__init__.py b/synapse/rest/__init__.py
@@ -145,7 +145,7 @@ def register_servlets(client_resource: HttpServer, hs: "HomeServer") -> None:
         password_policy.register_servlets(hs, client_resource)
         knock.register_servlets(hs, client_resource)
         appservice_ping.register_servlets(hs, client_resource)
-        if hs.config.server.enable_media_repo:
+        if hs.config.media.can_load_media_repo:
             from synapse.rest.client import media
 
             media.register_servlets(hs, client_resource)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix bug where using `synapse.app.media_repository` worker configuration would break the new media endpoints.