Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sliding Sync: Add cache to get_tags_for_room(...) #17730

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Sliding Sync: Add cache to get_tags_for_room(...) #17730

merged 5 commits into from
Sep 19, 2024

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Sep 18, 2024 •
edited
Loading

Add cache to get_tags_for_room(...)

This helps Sliding Sync because get_tags_for_room(...) is going to be used in #17695

Essentially, we're just trying to match get_account_data_for_room(...) which already has a tree cache.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@MadLittleMods MadLittleMods mentioned this pull request Sep 18, 2024
Merged
MadLittleMods
MadLittleMods commented Sep 18, 2024
View reviewed changes
tests/server_notices/test_resource_limits_server_notices.py
@@ -89,7 +89,7 @@ def prepare(self, reactor: MemoryReactor, clock: Clock, hs: HomeServer) -> None:
return_value="!something:localhost"
)
self._rlsn._store.add_tag_to_room = AsyncMock(return_value=None) # type: ignore[method-assign]
self._rlsn._store.get_tags_for_room = AsyncMock(return_value={}) # type: ignore[method-assign]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random lint that the linter called out

@MadLittleMods MadLittleMods marked this pull request as ready for review September 18, 2024 23:10
@MadLittleMods MadLittleMods requested a review from a team as a code owner September 18, 2024 23:10
@erikjohnston erikjohnston merged commit 83fc225 into develop Sep 19, 2024
39 checks passed
@erikjohnston erikjohnston deleted the madlittlemods/sliding-sync-add-cache-to-get_tags_for_room branch September 19, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees
No one assigned
Labels
A-Sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MadLittleMods @erikjohnston