Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create io.github.ellie-commons.teamcons.jorts.json #557

Merged
merged 8 commits into from
Feb 26, 2025

Conversation

teamcons
Copy link
Contributor

@teamcons teamcons commented Feb 24, 2025

Review Checklist

  • App opens
  • Does what it says
  • Categories match

AppData

  • Name is unique and non-confusing
  • Matches description
  • Matches screenshot
  • Launchable tag with matching ID
  • Release tag with matching version and YYYY-MM-DD date
  • OARS info matches

Flatpak

  • Uses elementary runtime
  • Sandbox permissions are reasonable

@teamcons teamcons requested a review from a team as a code owner February 24, 2025 21:21
zeebok
zeebok previously approved these changes Feb 24, 2025
@zeebok
Copy link
Contributor

zeebok commented Feb 24, 2025

@danirabbit I haven't seen this failure to find a manifest failure. Is this not finding something in the app's repo? The log doesn't really give any info. Does the flatpak file need to be a JSON file?

@teamcons
Copy link
Contributor Author

@danirabbit I haven't seen this failure to find a manifest failure. Is this not finding something in the app's repo? The log doesn't really give any info. Does the flatpak file need to be a JSON file?

could be it faceplants because the extension is .yaml and not .yml

@danirabbit
Copy link
Member

@teamcons probably haha

danirabbit

This comment was marked as resolved.

@teamcons
Copy link
Contributor Author

Thank you. The release description also wasnt good, so i did a better one, added correct branding and a second screenshot.
Ill do some update for translation soon and add more languages, but i dont want to wait on them for now.

danirabbit

This comment was marked as resolved.

@teamcons
Copy link
Contributor Author

Okay. Ive taken into account your feedback and made some more improvements.
This is looking super super serious and clean now >:3
I think end of the week or next week i will do a translation update and maybe a screenshot or two, but for now this needs to be out.

@teamcons teamcons closed this Feb 25, 2025
@teamcons teamcons reopened this Feb 25, 2025
@teamcons
Copy link
Contributor Author

The desktop comment didnt match the description. Shoddy work.
Now this should be enough.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, great work!

@danirabbit danirabbit merged commit 68a63cf into elementary:main Feb 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants